Archived discussion

Trimmed curve periodicity

ModelingThu, 03/17/2016 - 19:243 replies

Browse this forum
QuestionAuthor

Just found this:

Standard_Boolean Geom_TrimmedCurve::IsPeriodic () const
{
//return basisCurve->IsPeriodic();
return Standard_False;
}

What is the reason for that implementation? Shouldn't it

return basisCurve->IsPeriodic() && uTrim1 == basisCurve->FirstParameter() && uTrim2 == basisCurve->LastParameter();

?

Discussion

3 archived replies

Posts are displayed in their archived order.

01Commenter-1

Rather this:

return basisCurve->IsPeriodic() && Abs (uTrim2 - uTrim1 - Period()) < Precision::PConfusion();

to account for trims not aligned with natural bounds but still taking entire period.

02Author

Yes. :)

03Author

@OpenCASCADE team: isn't this a major issue? This could cause really strange bugs in my opinion, any comments on this? Or do I misunderstand something?