DiscussionsIssue archiveOCCT:Visualization

Archived issue #0008563

Incorrect comparison in StdPrs_ToolShadedShape::Normal

CommunityOCCT:Visualizationclosed2 public notes

Search issues

Description

This problem was reported in the Forum thread
http://www.opencascade.org/org/forum/thread_7915/?add_id=7915.

In StdPrs_ToolShadedeShape.cxx, lione 73 in function:

void StdPrs_ToolShadedShape::Normal(const TopoDS_Face& aFace,
Poly_Connect& pc,
TColgp_Array1OfDir& Nor)

the original line is:
if (!S.GetType() == GeomAbs_Plane) {

I think it should be sg like:
if (S.GetType() != GeomAbs_Plane) {
... // lots of normal calculation
}
else {
... //one normal calculation
}

Additional information

Documentation remark, added by ael 2005-07-01 07:40:10:

Changes:
Code correction
Modified entities:
StdPrs/ToolShadedShape/Normal

Public activity

2 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Dear APV,

Please add fix to bug :

Created an attachment (Attachment 1 (GZ))
Patch

to common testing workbench for ordinary bugs

Commenter 1
02Commenter 2
Dear Commenter 1,

According to the your recomendation, the source file for fixing OCC8563 has been
put to the queue KAS:dev:ros.