Archived issue #0022302
BRepMesh_IncrimentalMesh calls for each face of shape on vdisplay
Description
On vdisplay DRAW command (in StdSelect_BRepSelectionTool class)
BRepMesh_IncrimentalMesh calls for each face of shape. This fact is cause of
performance degradation and excepting the parallelization improvement in BRepMesh.
BRepMesh_IncrimentalMesh calls for each face of shape. This fact is cause of
performance degradation and excepting the parallelization improvement in BRepMesh.
Additional information
Documentation remark, added by Author 2011-03-10 09:21:00:
New features:
No
Improvements:
The calculation of triangulation of the shape for wireframe mode is right now.
Before changes the triangulation creates for each face separately. So this is
incorrect way and this fact is cause of performance degradation and excepting
the parallelization improvement in BRepMesh.
So now the calculation of triangulation performs if shape has no triangulation
or the deflection of it higher than new value.
Changes:
There is the one change in BRepBndLib API. Now the Add method from BRepBndLib
class has a one more parameter (bool useTriangulation) with Standard_True for
default value. This allow to add a bounding box for shape with various
deflection kind: if useTiangulation is true and triangulation is exist it takes
into account for calculating the bounding box elsewise a bounding box calculates
with standard deflection.
Modified entities:
TKTopAlgo:
BRepBndLib.cxx (BRepBndLib.cdl) - handle of Add method has been changed and
some changes in implementation;
TKV3d:
StdSelect_BRepSelectionTool.cxx - changes in GetSensitiveEntityForFace and
ComputeSensitive methods;
Prs3d_ShadedShape.gxx - changes in implementation of Add method
New features:
No
Improvements:
The calculation of triangulation of the shape for wireframe mode is right now.
Before changes the triangulation creates for each face separately. So this is
incorrect way and this fact is cause of performance degradation and excepting
the parallelization improvement in BRepMesh.
So now the calculation of triangulation performs if shape has no triangulation
or the deflection of it higher than new value.
Changes:
There is the one change in BRepBndLib API. Now the Add method from BRepBndLib
class has a one more parameter (bool useTriangulation) with Standard_True for
default value. This allow to add a bounding box for shape with various
deflection kind: if useTiangulation is true and triangulation is exist it takes
into account for calculating the bounding box elsewise a bounding box calculates
with standard deflection.
Modified entities:
TKTopAlgo:
BRepBndLib.cxx (BRepBndLib.cdl) - handle of Add method has been changed and
some changes in implementation;
TKV3d:
StdSelect_BRepSelectionTool.cxx - changes in GetSensitiveEntityForFace and
ComputeSensitive methods;
Prs3d_ShadedShape.gxx - changes in implementation of Add method
Public activity
4 archived notes
Participants are labeled by their role within this record.
Dear Oleg,
The bug number in the comments of the file Prs3d_ShadedShape.gxx
>> oan: BUG22302 - ...
I think it doesn't provide useful information, because if your modification works fine - there is no need to point out your changes with bug id. So it is better to be removed.
The remark is already corrected and in the SVN branch.
The bug number in the comments of the file Prs3d_ShadedShape.gxx
>> oan: BUG22302 - ...
I think it doesn't provide useful information, because if your modification works fine - there is no need to point out your changes with bug id. So it is better to be removed.
The remark is already corrected and in the SVN branch.
Dear Commenter 1,
SVN branch http://svn/svn/occt/branches/OCC22302 has been reviewed.
Remark (text of the comment in Prs3d_ShadedShape.gxx) was corrected.
SVN branch http://svn/svn/occt/branches/OCC22302 has been reviewed.
Remark (text of the comment in Prs3d_ShadedShape.gxx) was corrected.
Fix has been integrated to occt repository
Date: 2011-08-19 12:23:45 +0400 (Fri, 19 Aug 2011)
New Revision: 8872
Modified:
trunk/src/AIS/AIS_Shape.cxx
trunk/src/BRepBndLib/BRepBndLib.cdl
trunk/src/BRepBndLib/BRepBndLib.cxx
trunk/src/Prs3d/Prs3d_ShadedShape.gxx
trunk/src/Select3D/Select3D_SensitiveCurve.cxx
trunk/src/StdSelect/StdSelect_BRepSelectionTool.cxx
Date: 2011-08-19 12:23:45 +0400 (Fri, 19 Aug 2011)
New Revision: 8872
Modified:
trunk/src/AIS/AIS_Shape.cxx
trunk/src/BRepBndLib/BRepBndLib.cdl
trunk/src/BRepBndLib/BRepBndLib.cxx
trunk/src/Prs3d/Prs3d_ShadedShape.gxx
trunk/src/Select3D/Select3D_SensitiveCurve.cxx
trunk/src/StdSelect/StdSelect_BRepSelectionTool.cxx
Related records