DiscussionsIssue archiveOCCT:Visualization

Archived issue #0022332

Fix for Visual3d_Layer (linetype, linewidth and transparency)

CommunityOCCT:Visualizationclosed13 public notes

Search issues

Description

Post from the forum http://www.opencascade.org/org/forum/thread_20209/.
This is a patch in order to fix the non working linetype, linewidth and
transparency features of Visual3d_Layer class.

Additional information

Documentation remark, added by apl 2011-06-10 12:26:55:

Changes:
There are following changes in packages:
OpenGl package:
  1) The method that sets the line attributes in layer mode
     call_togl_set_line_attributes has been modified. Now it doesn't depends
     on static flag variables, instead of it method tries to acquire the
     current OpenGl attribute flags.
  2) The layer begin/end methods call_togl_begin_layer2d / call_togl_end_layer2d
     has been modified to keep the OpenGl attribute flags unchanged.
  3) The maximum count of predefined line styles for OpenGl driver has been
     defined as TEL_LS_MAX in InterfaceGraphic.hxx, this value is used during
     the line style list creation in TsmInitAttributes.

InterfaceGraphic package:
  1) The maximum count of default line styles has been defined as TEL_LS_MAX
     in InterfaceGraphic.hxx

ViewerTest package:
  1) DRAW command "vlayerline" has been added to test linewidth, linetype and
     transparency of the Visual3d_Layer class.
     The command draws a line and has the following arguments:
     >> vlayerline x1 y1 x2 y2 [linewidth=0.5] [linetype=0] [transparency=1.0]
     Linewidth in pixels, Transparency in range [0.0-1.0].

Public activity

13 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Anton,

This message is test of notification only
02Commenter 2
Anton,

Reload test script as known type of archived file of tcl script format.

--
[signature removed]
Mike

03Commenter 3
Dear Mikhail,

The test script is available in archived format: "Attachment 7 (GZ)".
04Commenter 4
This fix testes.
Regression was not found.
---
[signature removed]
Mike

05Commenter 5
We cannot integrate the fix based on patch from the user who have not signed CLA. Waiting for signature. Note that the fix contained in the tested branch is obsolete now due to re-implemented OpenGl package (see #0022819).
06Commenter 6
Dear Commenter 1,

The problems related to the issue are not found in redesigned OpenGl driver (#0022819). Thus, the git branch will be prepared only with draw testing commands.
07Commenter 7
Branch with draw command has been prepared in SVN:

http://svn/svn/occt/branches/OCC22332_DrawCommands
08Commenter 8
Dear Commenter 1,

The branch http://svn/svn/occt/branches/OCC22332_DrawCommands

is ready for tests.

The previous branch is not needed anymore and will be deleted as out-of-date.
09Commenter 2
Dear Commenter 1,
    SVN branch http://svn/svn/occt/branches/OCC22332_DrawCommands hes been moved to GIT CR22332 one.
    Workbench KAS:dev:apn-22332-occt was created from git branch CR22332
  (and apn-22332-products from svn trunk) and compiled on Linux platform.

  There is compilation error:
Error : Errors occured in Shell
/dn47/KAS/dev/apn-22332-occt/src/ViewerTest/ViewerTest_ViewerCommands.cxx:2222: error: expected unqualified-id before '==' token

Info : ----------------------- Compilation Report -----------------------
Info : Failed : :KAS:dev:apn-22332-occt:ViewerTest:source:ViewerTest_ViewerCommands.cxx
Info : -----------------------------------------------------------------

10Commenter 10
Compilation error has been corrected in GIT CR22332
11Commenter 11
Dear Commenter 1,

The GIT CR22332 branch is ready to be tested
12Commenter 2
Dear Commenter 1,
    Workbench KAS:dev:apn-22332-occt was updated from git branch CR22332
  (and apn-22332-products from svn trunk) and compiled on Linux platform.
  
    There are not regressions in apn-22332-products regarding to KAS:dev:products-20120306-opt

    Test case fir this fix is chl 937 D3. It's OK.
    
    See results in /QADisk/occttests/results/KAS/dev/apn-22332-products_15032012/lin
    See reference results in /QADisk/occttests/results/KAS/dev/products-20120306-opt_07032012/lin
    See test cases in /QADisk/occttests/tests/ED

13Commenter 1
Integrated into master

Related records