DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0022567

Speed up of math_FunctionSetRoot (used in Extrema)

CommunityOCCT:Modeling Algorithmsclosed14 public notes

Search issues

Description

RLN contribution. Detailed description:
      - Excluding recalculation in points which did not progress during iteration
      - Sqrt replaced with sqrt
      - minimized use of sqrt
      - static variable mydebug use surrounded with #ifdef DEB
      - minimized use of Abs in Bounds()

Additional information

Version 2 (correction from jgv)

Updating of function F (math_FunctionSetWithDerivatives) by the last value of solution was added before all calls of method GetStateNumber (if needed)

Modified files:

math_FunctionSetRoot.cxx

Modified methods:

void math_FunctionSetRoot::Perform

Public activity

14 archived notes

Participants are labeled by their role within this record.

01Commenter 2
SVN branch http://svn/svn/occt/branches/OCC22567_MathOptimization for this BUG
was reviewed.
- Unnecessary debug outputs should be completelly removed.
- Changes in sources should not be tracked in files themselves.
- Comment text should be indented from //.

Remarks was fixed and integrated into bug branch.
Patch is ready for testing.
02Commenter 2
Dear Commenter 1,
SVN branch (http://svn/svn/occt/branches/OCC22567_MathOptimization) was
testing, test results were compared with KAS:dev:products-651-opt

Regressions were not found
Test not necessary this branch

See results in /QADisk/OCCTtests/KAS/dev/ycy-products-2_05072011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html

03Commenter 1
Fix has been integrated to occt repository
Date: 2011-07-08 19:14:20 +0400 (Fri, 08 Jul 2011)
New Revision: 8663

Modified:
   trunk/src/math/math_FunctionSetRoot.cxx
Log:
OCC22567 Speed up of math_FunctionSetRoot (used in Extrema)
Developed by : RLN and KGV
04Commenter 4
Dear Kirill
During re-testing SVN branch
(http://svn/svn/occt/branches/OCC22567_MathOptimization) in chl 919 I1 (
Uncorrect work DRAW command "proj" in version dev ) regression was found
[signature removed]Yuri
05Commenter 2
If problem caused by this patch than I suggest to revert changes from TRUNK.

Notice that I probably will NOT investigate this regression in nearest future
because I'm not familiar within changed algorithm and suggested optimisations.
06Commenter 1
Modified:
   trunk/src/math/math_FunctionSetRoot.cxx
Log:
Rollback integration
OCC22567 Speed up of math_FunctionSetRoot (used in Extrema)
Developed by : RLN and KGV
07Commenter 7
SVN branch http://svn/svn/occt/branches/OCC22567 is ready to be reviewed
08Commenter 8
I have only two minor review remarks:

- Removed debug printouts in math_FunctionSetRoot.cxx could be worth keeping in commented state, instead of removal, for possible use

- Replacement of call to Sqrt() (OCCT wrapper) to sqrt() (C math function) should be reverted: we have OCCT wrappers in order to be able to add protections in them, and it is not wise to avoid using them

Apart of this, the correction looks Ok and is ready for testing
09Commenter 9
SVN branch http://svn/svn/occt/branches/22567 is ready for testing.
10Commenter 10
Please comment out couts and variable "debug"
11Commenter 11
SVN branch http://svn/svn/occt/branches/22567 is ready for testing. Please, take sources from the new branch "22567".
12Commenter 12
I have merged the branch with trunk and integrated a change to take into account my previous review remark: debug printouts to cout are packed to macro and disabled
13Commenter 3
Dear Commenter 1,
    Workbench apn-22567-occt was created from SVN branch http://svn/svn/occt/branches/22567 [^]
   (and apn-22567-products from trunk) and compiled on Linux platform.
    
    There are not regressions in apn-22567-products regarding to KAS:dev:products-20111229-opt.

    There several unstable tests:
chl 934 S8
pkv 913 A1
    
    See results in /QADisk/occttests/results/KAS/dev/apn-22567-products_13012012/lin
    See reference results in /QADisk/occttests/results/KAS/dev/products-20111229-opt_29122011/lin
    See test cases in /QADisk/occttests/tests/ED
14Commenter 1
Integrated to occt repository

Date: 2012-01-13 20:25:51 +0400 (Fri, 13 Jan 2012)
New Revision: 10039

Modified:
   trunk/src/math/math_FunctionSetRoot.cxx