DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0022572

Support of progress indicator in RWStl and optimization of reading Ascii.

CommunityOCCT:Data Exchangeclosed7 public notes

Search issues

Description

fix225
- Summary: Support of progress indicator in RWStl and optimization of reading Ascii.
Detailed description:
      - Progress indicator added to Write...(), Read...().
      - reduction of string buffers reallocation when writing STL files in ascii
mode

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 2
SVN branch http://svn/svn/occt/branches/OCC22572_RWStlPrIndicator for this BUG
was superficially reviewed.
- Original patch based on out-dated version of sources (thus directly applied
on recent revision will contain changes unrealted to fix).
- Generally when user interrupt function execution (using progress indiactor
interface) this function should return fail code rather then success.
- RWStl.cdl was uploaded to branch with CRLF endlines.
02Commenter 2
Additional remark: meshfromstl DRAWEXE command was not updated to use
introduced progress indicator.

All remarks should be fixed and new code revision is needed.
03Commenter 2
All remarks was fixed and integrated into bug branch.
Introduced progress indicator can be tested with this DRAWEXE scenario:

pload ALL;
vinit;
XProgress -t -g;
meshfromstl m1 bearing.stl;
XProgress +t +g;
meshfromstl m2 bearing.stl;

At second meshfromstl progress should be shown.

Patch is ready for testing (should be retrieved from SVN
http://svn/svn/occt/branches/OCC22572_RWStlPrIndicator).
04Commenter 4
Dear,Kirill
Please attach file "bearing.stl"
[signature removed]
Yuri.

05Commenter 2
2Yuri,
this STL file is placed in OCCT/data/stl/ path within standard OCCT installation.
06Commenter 6
Dear Commenter 1,
SVN branch (http://svn/svn/occt/branches/OCC22572_RWStlPrIndicator) was
testing, test results were compared with KAS:dev:products-651-opt

regressions were not found
Test case for this bug (chl/937/C5)

improvements chl 937 C5

See results in /QADisk/OCCTtests/KAS/dev/ycy-products-3_08072011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html

07Commenter 1
Fix has been integrated to occt repository

Date: 2011-07-12 21:24:21 +0400 (Tue, 12 Jul 2011)
New Revision: 8671

Modified:
   trunk/src/RWStl/RWStl.cdl
   trunk/src/RWStl/RWStl.cxx
   trunk/src/XSDRAWSTLVRML/XSDRAWSTLVRML.cxx

Related records