Archived issue #0022576
ShapeFix_Edge::SameParameter() now retains original 3D interval
Description
RLN: fix280
- Detailed description: See comments ShapeFix_Edge::SameParameter(). In the case
of periodic curve, 3D range lying
outside of a period was previously adjusted to fit into it. Thus
copyedge used different ranges than original
edge and in the case its pcurves had to be copied back, ranges and
pcurves became inconsistent.
Test case - edge-fix280.brep. Use fixshape command in Draw and check 3rd
edge. Withoutout the fix the pcurve
became wrong and new redundant edges were inserted.
- Dependency: None
Scenario to reproduce the problem.
-----------------------------------
In DRAW run
restore fix-280.brep e
fixshape fe e
check 3rd edge pcurves before and after fixshape.
- Detailed description: See comments ShapeFix_Edge::SameParameter(). In the case
of periodic curve, 3D range lying
outside of a period was previously adjusted to fit into it. Thus
copyedge used different ranges than original
edge and in the case its pcurves had to be copied back, ranges and
pcurves became inconsistent.
Test case - edge-fix280.brep. Use fixshape command in Draw and check 3rd
edge. Withoutout the fix the pcurve
became wrong and new redundant edges were inserted.
- Dependency: None
Scenario to reproduce the problem.
-----------------------------------
In DRAW run
restore fix-280.brep e
fixshape fe e
check 3rd edge pcurves before and after fixshape.
Public activity
7 archived notes
Participants are labeled by their role within this record.
SVN branch http://svn/svn/occt/branches/OCC22576_ShapefixSameparameter for
this BUG reviewed:
- Comments style should be corrected to follow coding rules.
Remarks was fixed and integrated into bug branch.
Branch is ready for testing.
this BUG reviewed:
- Comments style should be corrected to follow coding rules.
Remarks was fixed and integrated into bug branch.
Branch is ready for testing.
Dear Commenter 1,
SVN branch (http://svn/svn/occt/branches/OCC22576_ShapefixSameparameter) was
testing, regressions were not found, test results were compared with
KAS:dev:products-651-opt
Note:There is no enouth data to create test
See results in /KASDev/OCCTtests/KAS/dev/products-testing_16062011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html
SVN branch (http://svn/svn/occt/branches/OCC22576_ShapefixSameparameter) was
testing, regressions were not found, test results were compared with
KAS:dev:products-651-opt
Note:There is no enouth data to create test
See results in /KASDev/OCCTtests/KAS/dev/products-testing_16062011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html
Fix has been integrated to occt repository
Date: 2011-06-24 12:31:36 +0400 (Fri, 24 Jun 2011)
New Revision: 8629
Modified:
trunk/src/ShapeFix/ShapeFix_Edge.cxx
Log:
OCC22576 ShapeFix_Edge::SameParameter() now retains original 3D interval
Developed by : RLN
Revised by : SZY and KGV
Date: 2011-06-24 12:31:36 +0400 (Fri, 24 Jun 2011)
New Revision: 8629
Modified:
trunk/src/ShapeFix/ShapeFix_Edge.cxx
Log:
OCC22576 ShapeFix_Edge::SameParameter() now retains original 3D interval
Developed by : RLN
Revised by : SZY and KGV
Remarks for SZY:
There is no enouth data to create test case.
Please ask RLN to provide more data
There is no enouth data to create test case.
Please ask RLN to provide more data
New data from RLN are attached.
Plus additional comments:
restore fix-280-face.brep f
#1st edge matches the description
fixshape ff f
#exception is thrown in 6.5.0:
An exception was caught 007956AC : Standard_ConstructionError: Geom_TrimmedCurve
::parameters out of range
** Exception ** 007956AC : Standard_ConstructionError: Geom_TrimmedCurve::parame
ters out of range
Fix280 fixes the problem and produces correct resulting face.
Plus additional comments:
restore fix-280-face.brep f
#1st edge matches the description
fixshape ff f
#exception is thrown in 6.5.0:
An exception was caught 007956AC : Standard_ConstructionError: Geom_TrimmedCurve
::parameters out of range
** Exception ** 007956AC : Standard_ConstructionError: Geom_TrimmedCurve::parame
ters out of range
Fix280 fixes the problem and produces correct resulting face.
Dear Commenter 1,
SVN branch (http://svn/svn/occt/branches/OCC22576_ShapefixSameparameter) was
testing, test results were compared with KAS:dev:products-651-opt
regressions were not found
Test case for this bug (chl/936/Y7)
improvements chl 936 Y7
See results in /KASDev/OCCTtests/KAS/dev/products-testing_16062011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html
SVN branch (http://svn/svn/occt/branches/OCC22576_ShapefixSameparameter) was
testing, test results were compared with KAS:dev:products-651-opt
regressions were not found
Test case for this bug (chl/936/Y7)
improvements chl 936 Y7
See results in /KASDev/OCCTtests/KAS/dev/products-testing_16062011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html
Fix has been integrated to occt repository
Date: 2011-06-24 12:31:36 +0400 (Fri, 24 Jun 2011)
New Revision: 8629
Modified:
trunk/src/ShapeFix/ShapeFix_Edge.cxx
Date: 2011-06-24 12:31:36 +0400 (Fri, 24 Jun 2011)
New Revision: 8629
Modified:
trunk/src/ShapeFix/ShapeFix_Edge.cxx
Related records