Archived issue #0022590
Migration to FreeImage: revision of Xw and WNT packages
Description
In the frames of migration of all OCCT functionality dealing with images to
FreeImage services (Image_PixMap class), it is necessary to revise the code in
Xw and WNT packages and replace all code that deals with images by usage of
Image_PixMap.
This task looks more or less urgent for maintenance reasons, as without it
migration to FreeImage is incomplete and OCCT continues to use very old and
buggy image support code, new bug reports come from the community, etc.
This task should be assigned to Commenter 1 or APL, depending on who of them is more
available.
FreeImage services (Image_PixMap class), it is necessary to revise the code in
Xw and WNT packages and replace all code that deals with images by usage of
Image_PixMap.
This task looks more or less urgent for maintenance reasons, as without it
migration to FreeImage is incomplete and OCCT continues to use very old and
buggy image support code, new bug reports come from the community, etc.
This task should be assigned to Commenter 1 or APL, depending on who of them is more
available.
Public activity
4 archived notes
Participants are labeled by their role within this record.
Patch is ready for review in CR22590 branch.
Package Xw was cleaned up from unused functionality.
Since V2d package removal the only target for Xw_Window class is to provide OpenGL window definition for graphical driver.
Package Xw was cleaned up from unused functionality.
Since V2d package removal the only target for Xw_Window class is to provide OpenGL window definition for graphical driver.
Branch CR22590 reviewed without remarks, ready for testing.
Dear Commenter 3,
Branch CR22590 (and products from GIT master) was compiled on Linux and Windows platforms and tested with rebase.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)
products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 290140448 / 296830228
Total CPU difference: 25768.64000000112 / 23459.080000000526
Testing on Windows:
Total MEMORY difference: 404502636 / 405895868
Total CPU difference: 27365.578125 / 33344.734375
There are not serious differences in images found by testdiff.
Branch CR22590 (and products from GIT master) was compiled on Linux and Windows platforms and tested with rebase.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)
products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 290140448 / 296830228
Total CPU difference: 25768.64000000112 / 23459.080000000526
Testing on Windows:
Total MEMORY difference: 404502636 / 405895868
Total CPU difference: 27365.578125 / 33344.734375
There are not serious differences in images found by testdiff.
Related records
- #0022591 · related to · closedMigration to FreeImage: texture management
- #0023486 · related to · closedRemove obsolete image manipulation classes
- #0023538 · related to · closedMemory leak: cdata
- #0023537 · related to · closedUninitialized variable: MaxUserColor
- #0023885 · related to · closedInclusion of X11 header should be protected with macro