Archived issue #0022767
Extension of DRAW command fixshape
Description
Currently DRAW command fixshape does not provide any report on whether and what fixes have been made. The command should be extended by capabilities to output such information on request. This new capability should be used then in non-regression tests.
Public activity
13 archived notes
Participants are labeled by their role within this record.
Changes in ShapeFix_Face.cxx, ShapeFix_Shell.cxx and ShapeFix_Wire.cxx:
Removed duplicate messages. Most messages now attached to the shape, which was fixed.
Changes in SWDRAW_ShapeFix.cxx:
Added necessary breaks to the switch case statement. fixshape(line 389) now provides information about the number of fixes if called with option '+?' and store all modified shapes in compound if called with '*?'
SVN branch http://svn/svn/occt/branches/OCC22767 is ready to be reviewed
Removed duplicate messages. Most messages now attached to the shape, which was fixed.
Changes in SWDRAW_ShapeFix.cxx:
Added necessary breaks to the switch case statement. fixshape(line 389) now provides information about the number of fixes if called with option '+?' and store all modified shapes in compound if called with '*?'
SVN branch http://svn/svn/occt/branches/OCC22767 is ready to be reviewed
2dbv,
src/SHMessage/SHAPE.us,
it seems that changes are not in sync with French translation (SHAPE.fr)
src/ShapeFix/ShapeFix_Face.cxx, 1273
> SendWarning ( Message_Msg ("FixAdvFace.FixOrientation.MSG5") );//Wire on face was reversed
1) it seems some messages become unusable in code (FixAdvFace.FixOrientation.MSG10), maybe them should be completely removed from message files?
2) code style comment, could you please apply one coding style for spaces with parentheses within at least in one line of code?
src/SWDRAW/SWDRAW_ShapeFix.cxx, 457
> //Counting the number of each type of fixes. If the switch '*?' store all modified shapes in compound.
code style comment, I think that space between // and comments looks better and preferred in OCCT sources
src/SHMessage/SHAPE.us,
it seems that changes are not in sync with French translation (SHAPE.fr)
src/ShapeFix/ShapeFix_Face.cxx, 1273
> SendWarning ( Message_Msg ("FixAdvFace.FixOrientation.MSG5") );//Wire on face was reversed
1) it seems some messages become unusable in code (FixAdvFace.FixOrientation.MSG10), maybe them should be completely removed from message files?
2) code style comment, could you please apply one coding style for spaces with parentheses within at least in one line of code?
src/SWDRAW/SWDRAW_ShapeFix.cxx, 457
> //Counting the number of each type of fixes. If the switch '*?' store all modified shapes in compound.
code style comment, I think that space between // and comments looks better and preferred in OCCT sources
added changes in src/SHMessage/SHAPE.fr
removed FixAdvFace.FixOrientation.MSG10 message as no longer used in the code.
minor changes in source files: corrections associated with the coding style
branch http://svn/svn/occt/branches/OCC22767 is ready to be reviewed
removed FixAdvFace.FixOrientation.MSG10 message as no longer used in the code.
minor changes in source files: corrections associated with the coding style
branch http://svn/svn/occt/branches/OCC22767 is ready to be reviewed
Some comments from review:
- resource files SHMessage/SHAPE.* seem to have problem with text encoding: whole file is marked as change
- Messages in FixFace that apply to wires (e.g. FixAdvFace.FixOrientation.MSG11) should perhaps be attached to relevant wires rather than by default (obviously to whole face)
- Message FixWire.FixDegenerated.MSG5 was commented out previously with remark "to avoid extra messages"; it shall probably be left commented
- resource files SHMessage/SHAPE.* seem to have problem with text encoding: whole file is marked as change
- Messages in FixFace that apply to wires (e.g. FixAdvFace.FixOrientation.MSG11) should perhaps be attached to relevant wires rather than by default (obviously to whole face)
- Message FixWire.FixDegenerated.MSG5 was commented out previously with remark "to avoid extra messages"; it shall probably be left commented
Messages in ShapeFix_Face now attached to the relevant wires.
Message FixWire.FixDegenerated.MSG0 commented out.
Dear Andrey,
Please review the fix.
Message FixWire.FixDegenerated.MSG0 commented out.
Dear Andrey,
Please review the fix.
No remarks, the fix is ready for testing
Dear Commenter 1,
Workbench KAS:dev:mkv-22767-occt was created from SVN branch http://svn/svn/occt/branches/OCC22767
(and mkv-22767-products from trunk) and compiled on Linux platform.
There are following regressions in mkv-22767-products regarding to KAS:dev:products-652-opt:
xigs 103 U3
See results in /QADisk/occttests/results/KAS/dev/mkv-22767-products_12122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Workbench KAS:dev:mkv-22767-occt was created from SVN branch http://svn/svn/occt/branches/OCC22767
(and mkv-22767-products from trunk) and compiled on Linux platform.
There are following regressions in mkv-22767-products regarding to KAS:dev:products-652-opt:
xigs 103 U3
See results in /QADisk/occttests/results/KAS/dev/mkv-22767-products_12122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Due to changes in /src/ShapeFix/ShapeFix_Face.cxx (line 1682) "tpstat" command now displays a warning messages for this test. Therefore the test case results must be modified in accordance with the current output.
Dear Andrey,
Please review.
Dear Andrey,
Please review.
Please modify test case "xigs 103 U3" as per above comment, and integrate
Dear Commenter 1,
Test case xigs/103/U3 will be modified afther integration this fix.
Test case xigs/103/U3 will be modified afther integration this fix.
Dear dbv,
I need the examples for testing new capability of fixshape-command.
I need the examples for testing new capability of fixshape-command.
Dear mkv,
I attached some files for testing.
"fixshape" usage:
Draw> fixshape res a +?
or
Draw> fixshape res a *?
For Attachment 1 (BREP) output should look like:
Draw[2]> rest D:/Shapes/Attachment 1 (BREP) a
a
Draw[3]> fixshape res a +?
Fix Count
------------------------------------------------------------
Improperly connected shell split into parts 1
Wire on face was reversed 3
------------------------------------------------------------
Draw[4]> fixshape res a *?
Fix Count
------------------------------------------------------------
Improperly connected shell split into parts 1
Wire on face was reversed 3
------------------------------------------------------------
Modified shapes saved in compound: res_m
Draw[5]>
I attached some files for testing.
"fixshape" usage:
Draw> fixshape res a +?
or
Draw> fixshape res a *?
For Attachment 1 (BREP) output should look like:
Draw[2]> rest D:/Shapes/Attachment 1 (BREP) a
a
Draw[3]> fixshape res a +?
Fix Count
------------------------------------------------------------
Improperly connected shell split into parts 1
Wire on face was reversed 3
------------------------------------------------------------
Draw[4]> fixshape res a *?
Fix Count
------------------------------------------------------------
Improperly connected shell split into parts 1
Wire on face was reversed 3
------------------------------------------------------------
Modified shapes saved in compound: res_m
Draw[5]>
Integration into trunk of occt repository
Date: 2011-12-16 15:18:18 +0400 (Fri, 16 Dec 2011)
New Revision: 9763
Modified:
trunk/src/SHMessage/SHAPE.fr
trunk/src/SHMessage/SHAPE.us
trunk/src/SWDRAW/SWDRAW_ShapeFix.cxx
trunk/src/ShapeFix/ShapeFix_Face.cxx
trunk/src/ShapeFix/ShapeFix_Shell.cxx
trunk/src/ShapeFix/ShapeFix_Wire.cxx
Date: 2011-12-16 15:18:18 +0400 (Fri, 16 Dec 2011)
New Revision: 9763
Modified:
trunk/src/SHMessage/SHAPE.fr
trunk/src/SHMessage/SHAPE.us
trunk/src/SWDRAW/SWDRAW_ShapeFix.cxx
trunk/src/ShapeFix/ShapeFix_Face.cxx
trunk/src/ShapeFix/ShapeFix_Shell.cxx
trunk/src/ShapeFix/ShapeFix_Wire.cxx