Archived issue #0022822
Skipping of the first and the last edges of a wire for opened wires
Description
There is a bug in consideration of self-intersection in the method ShapeAnalysis_Wire::CheckSelfIntersection(). A closed wire is processed correctly. But an opened wire skips the first and the last edges from consideration.
Public activity
16 archived notes
Participants are labeled by their role within this record.
The method ShapeAnalysis_Wire::CheckSelfIntersection() returns false for the wire seldIntersectingOpenWire.png attached to this issue.
The fix is commited to http://svn/svn/occt/branches/22822. The only file is modified is ShapeAnalysis_Wire.cxx
Dear Commenter 1, revise please the fix (or find a guy who would do it). Many thanks!
Dear Vlad,
You must define reviewer yourself, set status resolved and assign issue to reviewer.
You must define reviewer yourself, set status resolved and assign issue to reviewer.
Dear Catia,
Could you review my fix, please?
Thanks,
Vlad
Could you review my fix, please?
Thanks,
Vlad
The file Attachment 2 (BREP) represents an open self-intersecting wire.
I have no remarks; please test
Dear Cathia,
Thank you very much!
:-)
Thank you very much!
:-)
Could you integrate the fix into OCCT, please?
Dear Commenter 1,
Workbench KAS:dev:apn-OCC22822-occt was created from SVN branch http://svn/svn/occt/branches/OCC22822
(and apn-OCC22822-products from trunk) and compiled on Linux platform.
There are not regressions in apn-OCC22822-products regarding to KAS:dev:products-652-opt.
See results in /QADisk/occttests/results/KAS/dev/apn-OCC22822-products_06122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Workbench KAS:dev:apn-OCC22822-occt was created from SVN branch http://svn/svn/occt/branches/OCC22822
(and apn-OCC22822-products from trunk) and compiled on Linux platform.
There are not regressions in apn-OCC22822-products regarding to KAS:dev:products-652-opt.
See results in /QADisk/occttests/results/KAS/dev/apn-OCC22822-products_06122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Dear Vlad,
Please create the new draw test command to check usage of ShapeAnalysis
[signature removed]
Kate
Please create the new draw test command to check usage of ShapeAnalysis
[signature removed]
Kate
Dear Catherina,
Dear Mikhail,
A new draw command checkselfintersection is added in 22822 branch. It is implemented in SWDRAW_ShapeAnalysis.cxx.
Use the command please with an attached shape. Before modification (before bug correction) the command returns false (no self-intersection). After the modification (when the bug is fixed) the command returns true (detects a self-intersection).
Any questions are welcome!
Vlad
Dear Mikhail,
A new draw command checkselfintersection is added in 22822 branch. It is implemented in SWDRAW_ShapeAnalysis.cxx.
Use the command please with an attached shape. Before modification (before bug correction) the command returns false (no self-intersection). After the modification (when the bug is fixed) the command returns true (detects a self-intersection).
Any questions are welcome!
Vlad
A draw command for tests is ready.
Mikhail,
Please create testing case and change status to tested.
Please create testing case and change status to tested.
Dear Commenter 1,
Test case for this fix is chl/934/R3. It is OK.
Test case for this fix is chl/934/R3. It is OK.
Integrated into trunk of occt repository
Date: 2012-02-10 13:57:58 +0400 (Fri, 10 Feb 2012)
New Revision: 10407
Modified:
trunk/src/SWDRAW/SWDRAW_ShapeAnalysis.cxx
trunk/src/ShapeAnalysis/ShapeAnalysis_Wire.cxx
Date: 2012-02-10 13:57:58 +0400 (Fri, 10 Feb 2012)
New Revision: 10407
Modified:
trunk/src/SWDRAW/SWDRAW_ShapeAnalysis.cxx
trunk/src/ShapeAnalysis/ShapeAnalysis_Wire.cxx