DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0022934

Wrong delete operator in IGESSelect_SelectFromDrawing.cxx / IGESSelect_SelectFromSingleView.cxx

CommunityOCCT:Data Exchangeclosed8 public notes

Search issues

Description

IGESSelect_SelectFromDrawing.cxx (line 44) / IGESSelect_SelectFromSingleView.cxx (line 31) should use the "delete []" operator as arrays are deleted.

Additional information

Delete some unused code in IGESSelect/IGESSelect_SelectFromDrawing::RootResult(), IGESSelect_SelectFromSingleView::RootResult()

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 1
I guess we shall remove use of variable nums and other irrelevant code around it in both these classes, as it is not used (at least I do not see any use of it -- it was probably some debug stuff?).
02Commenter 2
SVN branch http://svn/svn/occt/branches/OCC22934 (revision 10394) is ready to be reviewed.
03Commenter 3
No remarks, please test
04Commenter 4
Dear Commenter 1,
Workbench KAS:dev:mkv-22934-occt was created from SVN branch http://svn/svn/occt/branches/OCC22934
(and mkv-22934-products from trunk) and compiled on Linux platform.


05Commenter 5
Dear Commenter 1,
Workbench KAS:dev:mkv-22934-occt from SVN branch http://svn/svn/occt/branches/OCC22934
(and mkv-22934-products from trunk) was successfully compiled and tested on Linux.

There are following regressions in mkv-22934-products regarding to KAS:dev:products-20120210-opt

chl 934 P9

See results in /QADisk/occttests/results/KAS/dev/mkv-22934-products_10022012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120210-opt_10022012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification

06Commenter 6
The case chl 934 P9 should not be considered a regression here: it corresponds to issue #22967 which has been integrated to trunk (rev 10423) after last merge of branch OCC22934 with trunk (rev 10418).
07Commenter 1
Integrated into trunk of occt repository

Date: 2012-02-17 16:04:22 +0400 (Fri, 17 Feb 2012)
New Revision: 10508

Modified:
   trunk/src/IGESSelect/IGESSelect_SelectFromDrawing.cxx
   trunk/src/IGESSelect/IGESSelect_SelectFromSingleView.cxx
08Author
Verified. Please close.