Archived issue #0022953
strcat expects null-terminated destination string
Description
The problem is in line 182 in OSD_Host.cxx:
char noaddress[100];
strcat(noaddress,"NO-ETHERNET-ADDRESS-AVAILABLE-ON-");
Solution: use strcpy instead of strcat.
strcpy (noaddress, "NO-ETHERNET-ADDRESS-AVAILABLE-ON-");
char noaddress[100];
strcat(noaddress,"NO-ETHERNET-ADDRESS-AVAILABLE-ON-");
Solution: use strcpy instead of strcat.
strcpy (noaddress, "NO-ETHERNET-ADDRESS-AVAILABLE-ON-");
Public activity
6 archived notes
Participants are labeled by their role within this record.
Please remove all the stuff related to getting ethernet address on ancient platforms (search for "Ethernet"). The ones I find are: file Standard_Geteth.cxx, files ethernet.h-* in OSD, method EthernetAddress in OSD::Host, and related static stuff in the cxx file.
Stuff related to getting Ethernet address on ancient platforms has been removed:
1. file src/Standard/Standard_Geteth.cxx
2. files src/OSD/ethernet.h-*
3. method EthernetAddress in OSD::Host and related static stuff in the file src/OSD/OSD_Host.cxx
Branch http://svn/svn/occt/branches/OCC22953 is ready to be reviewed.
Dear Andrey,
Please review.
1. file src/Standard/Standard_Geteth.cxx
2. files src/OSD/ethernet.h-*
3. method EthernetAddress in OSD::Host and related static stuff in the file src/OSD/OSD_Host.cxx
Branch http://svn/svn/occt/branches/OCC22953 is ready to be reviewed.
Dear Andrey,
Please review.
No remarks, please test
Dear Commenter 1,
Workbench aan-22953-occt was created from SVN branch http://svn/svn/occt/branches/OCC22953
(and aan-22953-products from trunk) and compiled on Linux platform.
There are not regressions in aan-22953-products regarding to KAS:dev:products-20120210-opt
See results in /QADisk/occttests/results/KAS/dev/aan-22953-products_15022012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120210-opt_10022012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Workbench aan-22953-occt was created from SVN branch http://svn/svn/occt/branches/OCC22953
(and aan-22953-products from trunk) and compiled on Linux platform.
There are not regressions in aan-22953-products regarding to KAS:dev:products-20120210-opt
See results in /QADisk/occttests/results/KAS/dev/aan-22953-products_15022012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120210-opt_10022012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Integrated into trunk of occt repository
Date: 2012-02-17 11:58:20 +0400 (Fri, 17 Feb 2012)
New Revision: 10495
Removed:
trunk/src/OSD/ethernet.h-dec
trunk/src/OSD/ethernet.h-sgi
trunk/src/Standard/Standard_Geteth.cxx
Modified:
trunk/src/OSD/FILES
trunk/src/OSD/OSD_Host.cdl
trunk/src/OSD/OSD_Host.cxx
trunk/src/Standard/FILES
Date: 2012-02-17 11:58:20 +0400 (Fri, 17 Feb 2012)
New Revision: 10495
Removed:
trunk/src/OSD/ethernet.h-dec
trunk/src/OSD/ethernet.h-sgi
trunk/src/Standard/Standard_Geteth.cxx
Modified:
trunk/src/OSD/FILES
trunk/src/OSD/OSD_Host.cdl
trunk/src/OSD/OSD_Host.cxx
trunk/src/Standard/FILES
Verified. Please close.