DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0022961

Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it) (cppcheck report)

CommunityOCCT:Data Exchangeclosed8 public notes

Search issues

Description

in VrmlData_Scene.cxx (line 1015) / VrmlData_Group.cxx (line 276)

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Added 0-termination for "buf" variable.

Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.

Dear Andrey,
Please review.
02Commenter 2
TCollection_AsciiString used instead of char arrays

Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.

Dear Andrey,
Please review.
03Commenter 3
Review remark: in VrmlData_Group.cxx, if '.' is found in the string, the string should be truncated after it is replaced by '_' (at least it seems how it were before the fix). Please check and correct
04Commenter 4
Remark fixed.

Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.

Dear Andrey,
Please review.
05Commenter 5
No remarks; please test
06Commenter 6
Dear Commenter 1,
SVN branch http://svn/svn/occt/branches/OCC22961 has been moved to GIT CR22961 one.
Workbench KAS:dev:mkv-22961-occt was created from git branch CR22961
(and mkv-22961-products from svn trunk) and compiled on Linux platform.

There are not regressions in mkv-22961-products regarding to KAS:dev:products-20120306-opt

See results in /QADisk/occttests/results/KAS/dev/mkv-22961-products_11032012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120306-opt_07032012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
07Commenter 1
Integrated into master
08Author
Verified. Please close.