Archived issue #0022961
Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it) (cppcheck report)
Description
in VrmlData_Scene.cxx (line 1015) / VrmlData_Group.cxx (line 276)
Public activity
8 archived notes
Participants are labeled by their role within this record.
Added 0-termination for "buf" variable.
Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.
Dear Andrey,
Please review.
Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.
Dear Andrey,
Please review.
TCollection_AsciiString used instead of char arrays
Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.
Dear Andrey,
Please review.
Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.
Dear Andrey,
Please review.
Review remark: in VrmlData_Group.cxx, if '.' is found in the string, the string should be truncated after it is replaced by '_' (at least it seems how it were before the fix). Please check and correct
Remark fixed.
Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.
Dear Andrey,
Please review.
Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed.
Dear Andrey,
Please review.
No remarks; please test
Dear Commenter 1,
SVN branch http://svn/svn/occt/branches/OCC22961 has been moved to GIT CR22961 one.
Workbench KAS:dev:mkv-22961-occt was created from git branch CR22961
(and mkv-22961-products from svn trunk) and compiled on Linux platform.
There are not regressions in mkv-22961-products regarding to KAS:dev:products-20120306-opt
See results in /QADisk/occttests/results/KAS/dev/mkv-22961-products_11032012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120306-opt_07032012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
SVN branch http://svn/svn/occt/branches/OCC22961 has been moved to GIT CR22961 one.
Workbench KAS:dev:mkv-22961-occt was created from git branch CR22961
(and mkv-22961-products from svn trunk) and compiled on Linux platform.
There are not regressions in mkv-22961-products regarding to KAS:dev:products-20120306-opt
See results in /QADisk/occttests/results/KAS/dev/mkv-22961-products_11032012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120306-opt_07032012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Integrated into master
Verified. Please close.