Archived issue #0023140
Suspicious if
Description
src\BRepFill\BRepFill_TrimEdgeTool.cxx , line #0000183
if(AC.GetType() != GeomAbs_Circle || AC.GetType() != GeomAbs_Line) {
Tol *= 100.;
}
Condition is always true, I don't know if the original intention was to agument the tolerance only for cicle and lines, or the opposite
if(AC.GetType() != GeomAbs_Circle || AC.GetType() != GeomAbs_Line) {
Tol *= 100.;
}
Condition is always true, I don't know if the original intention was to agument the tolerance only for cicle and lines, or the opposite
Public activity
4 archived notes
Participants are labeled by their role within this record.
Condition that is always true was replaced with assigning a variable 'Tol' to Precision::Confusion().
The Git branch CR23140 is ready to be reviewed.
Dear oan, please review.
The Git branch CR23140 is ready to be reviewed.
Dear oan, please review.
Dear JGV,
please review.
please review.
No remarks
Dear Commenter 3,
Branch CR23140 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regression:
Not detected
Improvements:
Not detected
Testing case:
Not needed
Branch CR23140 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regression:
Not detected
Improvements:
Not detected
Testing case:
Not needed
Related records