DiscussionsIssue archiveOCCT:Visualization

Archived issue #0023209

Potentially unmatched XOpenDisplay() and XCloseDisplay() calls in some OCCT packages

CommunityOCCT:Visualizationclosed3 public notes

Search issues

Description

XOpenDisplay() calls should have a matching XCloseDisplay() call.
Missing XCloseDisplay() call has been found at least in OSD_FontMgr class.

It is also necessary to check also Xw_GraphicDevice and OpenGl_Display classes work with X display as expected, without creating X server connections that remain unclosed.

Public activity

3 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Most of problems with unmatched XOpenDisplay() have been fixed in related issues.
Fixed display connection management in Draw_Window.

Dear Sergey, could you please review the git branch CR23209.
02Commenter 2
Branch CR23209 reviewed without remarks, ready fro testing.
03Commenter 3
Dear BugMaster,

Branch CR23209 (and products from GIT master) was compiled on Linux and Windows platforms.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 39 (39 on master)

products component :
Linux: 10 (10 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 238931308 / 239611028
Total CPU difference: 20013.680000000848 / 16232.879999999803

Testing on Windows:
Total MEMORY difference: 326702408 / 326592864
Total CPU difference: 13384.203125 / 14605.28125

There are not serious differences in images found by testdiff.

Related records