DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0023288

IntCurve_IntConicConic_1.cxx: if(A) {...} else if (A){...} pattern detected

CommunityOCCT:Modeling Algorithmsclosed5 public notes

Search issues

Description

In lines 200 and 244 occurs the same if-condition:

if(dO1O2 > AbsR1mR2-Tol)

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 1
In line 244 of IntCurve_IntConicConic_1.cxx there was unrealizable condition 'else if(dO1O2 > AbsR1mR2-Tol)'.
Previous condition block in line 200 covers two cases of circle intersection:
1) one circle contacts another one from inside,
2) one circle intersects another one.
02Commenter 2
The Git branch CR23288 is ready to be reviewed.
Dear oan, please review.
03Commenter 1
Dear JGV,
I have no comments.
Please consider consistency of the fix from your side.
04Commenter 4
No remarks
05Commenter 5
Dear Commenter 2,
Branch CR23288 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed

Related records