Archived issue #0023288
IntCurve_IntConicConic_1.cxx: if(A) {...} else if (A){...} pattern detected
Description
In lines 200 and 244 occurs the same if-condition:
if(dO1O2 > AbsR1mR2-Tol)
if(dO1O2 > AbsR1mR2-Tol)
Public activity
5 archived notes
Participants are labeled by their role within this record.
In line 244 of IntCurve_IntConicConic_1.cxx there was unrealizable condition 'else if(dO1O2 > AbsR1mR2-Tol)'.
Previous condition block in line 200 covers two cases of circle intersection:
1) one circle contacts another one from inside,
2) one circle intersects another one.
Previous condition block in line 200 covers two cases of circle intersection:
1) one circle contacts another one from inside,
2) one circle intersects another one.
The Git branch CR23288 is ready to be reviewed.
Dear oan, please review.
Dear oan, please review.
Dear JGV,
I have no comments.
Please consider consistency of the fix from your side.
I have no comments.
Please consider consistency of the fix from your side.
No remarks
Dear Commenter 2,
Branch CR23288 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regressions:
Not detected
Improvements:
Not detected
Testing cases:
Not needed
Branch CR23288 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regressions:
Not detected
Improvements:
Not detected
Testing cases:
Not needed
Related records