DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0023292

The variable 'k' is being used for this loop and for the outer loop.

CommunityOCCT:Modeling Algorithmsclosed5 public notes

Search issues

Description

In gccana_circ2d3tan_2.cxx line 212

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Before defining a new variable for the inner loop the function GccAna_Circ2d3Tan in GccAna_Circ2d3Tan_2.cxx returned an incorrect set of circle tangents. The reason was in fact that inner loop changed variable 'k' and therefore the program did only one iteration in the outer loop instead of two.
02Commenter 2
Git branch CR23292 is ready to be reviewed.
Dear Oleg, please review.
03Commenter 1
Dear JGV,
Current fix will produce more solutions than source implementation.
Could you please consider consistency of the changes made by ABA?
04Commenter 4
No remarks
05Commenter 2
Dear Commenter 3,
Branch CR23292 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed