Archived issue #0023309
The 'then' statement is equivalent to the 'else' statement in TopOpeBRep_EdgesFiller.cxx
Description
In method TopOpeBRep_EdgesFiller::SetShapeTransition, line 348.
The else-if-action is equal to the else-action.
I'm not sure about the intention of the method so I just add it to the group of 'Suspicious ifs'.
The else-if-action is equal to the else-action.
I'm not sure about the intention of the method so I just add it to the group of 'Suspicious ifs'.
Public activity
4 archived notes
Participants are labeled by their role within this record.
Git branch CR23309 is ready to be reviewed.
My suspicion is that else-if clause might correspond to FACE-EDGE case
Reviewed.
Dear Commenter 1,
Branch CR23309 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)
products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 242969116 / 243421964
Total CPU difference: 16724.459999999977 / 15476.330000000036
Testing on Windows:
Total MEMORY difference: 345993676 / 346193616
Total CPU difference: 16869.296875 / 21619.828125
There are not serious differences in images found by testdiff.
Branch CR23309 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)
products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 242969116 / 243421964
Total CPU difference: 16724.459999999977 / 15476.330000000036
Testing on Windows:
Total MEMORY difference: 345993676 / 346193616
Total CPU difference: 16869.296875 / 21619.828125
There are not serious differences in images found by testdiff.
Related records