Archived issue #0023312
Suspicious for loop in BiTgte_Blend.cxx
Description
Starting in line 2327:
Standard_Integer NbS = NbSurfaces();
NbS = 0;
for (Standard_Integer i = 1; i <= NbS; i++) {
const TopoDS_Shape& S1 = SupportShape1(i);
...
Because 'NbS' is set to '0' the loop will not be run at all.
Was this intended?
Standard_Integer NbS = NbSurfaces();
NbS = 0;
for (Standard_Integer i = 1; i <= NbS; i++) {
const TopoDS_Shape& S1 = SupportShape1(i);
...
Because 'NbS' is set to '0' the loop will not be run at all.
Was this intended?
Public activity
4 archived notes
Participants are labeled by their role within this record.
Line 'NbS=0;' was deleted to allow a following loop be executable.
The Git branch CR23312 is ready to be reviewed.
Dear oan, please review.
Dear oan, please review.
Let's test it to see the effect
Dear Commenter 1,
Branch CR23312 (and master from occt-products) was compiled on Linux and Windows platforms and tested.
Regressions:
Not detected
Improvements:
Not detected
Testing cases:
Not needed
Branch CR23312 (and master from occt-products) was compiled on Linux and Windows platforms and tested.
Regressions:
Not detected
Improvements:
Not detected
Testing cases:
Not needed
Related records