Archived issue #0023320

The body of 'OpenCollector' function is fully equivalent to the body of 'CloseCollector' function

CommunityOCCT:Visualizationclosed4 public notes

Description

AIS_InteractiveContext::CloseCollector() in AIS_InteractiveContext.lxx
and
AIS_InteractiveContext::OpenCollector() in AIS_InteractiveContext.cxx

set the value of 'myIsCollClosed' to Standard_True

I guess when opening the collector this flag should be set to Standard_False.

Public activity

4 archived notes

Participants are labeled by their role within this record.

01Author2012-07-18 14:56

Corresponding git branch pushed. Please review.

02Commenter 22012-07-19 19:56

No remarks, please test

03Commenter 32012-07-19 20:13

Note that methods CloseCollector() and OpenCollector() are not used neither in OCCT code nor in applications I could check. Method IsCollectorClosed() is used in single place: at line 760 in AIS_InteractiveContext_2.cxx (method PurgeDisplay(), which in turn is used only in single place in QADraw.cxx). Do we need this stuff at all (and in AIS2d_InteractiveContect, too)?

04Commenter 12012-07-23 18:08

Dear Commenter 2,
The workbenches
KAS:dev:mkv-23320-occt (GIT branch CR23320)
KAS:dev:mkv-23320-products (GIT master)
were compiled on Linux platform and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed

See results in /QADisk/occttests/results/KAS/dev/mkv-23320-products_20072012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120706-opt_06072012/lin
See test cases in /QADisk/occttests/tests/ED