Archived issue #0023327
There are identical sub-expressions to the left and to the right of the '&&' operator
Description
In TObj_Model.cxx, TObj_Model::updateBackReferences, line 632
for(;aChildren->More() && aChildren->More(); aChildren->Next())
the condition 'aChildren->More() && aChildren->More()' seems to be redundant.
Could one check be deleted or maybe some additional verification was meant to be done at this place (although it doesn't look like because there are not many variables to check at this point)?
for(;aChildren->More() && aChildren->More(); aChildren->Next())
the condition 'aChildren->More() && aChildren->More()' seems to be redundant.
Could one check be deleted or maybe some additional verification was meant to be done at this place (although it doesn't look like because there are not many variables to check at this point)?
Public activity
3 archived notes
Participants are labeled by their role within this record.
Fixed in branch CR23327.
Review it, please.
Review it, please.
Reviewed!
Dear Commenter 3,
Branch CR23327 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regression:
Not detected
Improvements:
Not detected
Testing case:
Not needed
Branch CR23327 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regression:
Not detected
Improvements:
Not detected
Testing case:
Not needed