Archived issue #0023354

The use of 'if (A) {...} else if (A) {...}' pattern was detected.

CommunityOCCT:DRAWclosed6 public notes

Search issues

Description

In ViewerTest_ViewerCommands, lines 324 and 346.

The case

else if ( !strcasecmp(buf_ret, "D") ) {

is handled twice.

Was it maybe "R" that was meant for reset and "D" for something else?

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 1
second else was deleted, now "D" is hotkey for reset view and removing selected object is impossible by hotkeys
help message was rewrited according to these changes, also hotkeys "R","L" and "B" added to help

Git branch CR23266 is ready to be reviewed.

Dear Anton,
please review.
02Commenter 2
Hi, Irina.

Branch CR23354 reviewed (I'm sure you meant it instead of 23266). All remarks (minor) are already in the branch:
1) comments in hot key parsing revised (there were left, right, bottom commented as "top").
2) help menu completed with other available hot keys. "U" - unset display mode, "Z" - switch Z clipping On/Off.
03Commenter 3
I would like to remind you workflow of issue "status" in bug advancement (see picture above):

Please don't forget to change issue's status:
* when bug fixed - developer should change its status to "resolved" and the bug should be assigned to reviewer.

So, could you please change status to resolved, and then to reviewed (I'm already done it) and ask bug master to test the fix?
04Commenter 1
Hi, Anton.
Sorry for these mistakes, I'll do that you say next time.
05Commenter 1
please test.
06Commenter 6
Dear Commenter 2,
Branch CR23354 (and master from occt-products) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed