DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0023615

Wrong parameter value calculating in ShapeAnalysis_Curve

Open CASCADEOCCT:Modeling Algorithmsclosed8 public notes

Search issues

Description

ShapeAnalysis_Curve::CurveNewton function sometimes returns wrong U parameter value (about 90.) That leads to crash in tests:
 
heal split_continuity_advanced W6
heal surface_to_revolution_advanced W6 Y5

Steps to reproduce

in DRAW write:
test heal split_continuity_advanced W6 true
or
test heal surface_to_revolution_advanced W6 true
or
test heal surface_to_revolution_advanced Y5 true

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Dear abv,
The fix has been integrated into branch CR23615.
Please, review.
02Commenter 2
Reviewed; the branch has been rebased on the current master; some corrections (formatting, cleaning obsolete code, removing TODO in tests) are made. Please test
03Commenter 3
Dear BugMaster,
Branch CR23615 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.

Regressions:
did 011 A6 C9
xsat 101 G6

Improvements:
Not detected

See results in
/QADisk/occttests/results/KAS/dev/CR23615-master-products_06122012/lin
See reference results in
/QADisk/occttests/results/KAS/dev/IR-2012-11-15-master-products_15112012/lin
See test cases in /QADisk/occttests/tests/ED
04Commenter 4
Dear gka,
Regressions were fixed.
Please, review.
05Commenter 5
Branch CR23615 was reviewed
06Commenter 6
Dear BugMaster,
Branch CR23615 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Branch CR23615 was rebased on the current master.
Conflicts files was merget by MKV.

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 85 (85 on master)

products component :
Linux: 9 (9 on master)
Windows: 54 (54 on master)

Regressions:
did 010 C6
xsat 101 G6
See results in
/QADisk/occttests/results/KAS/dev/CR23615-master-products_25012013/lin
See reference results in
/QADisk/occttests/results/KAS/dev/IR-2013-01-18-master-products_18012013/lin
See test cases in /QADisk/occttests/tests/ED

Improvements:
No improvements

Testing cases:
heal split_continuity_advanced(015) W6 - OK
heal surface_to_revolution_advanced(017) W6 Y5 - OK

Testing on Linux:
Total MEMORY difference: 222766492 / 223055260
Total CPU difference: 9145.760000000058 / 8309.2600000005

Testing on Windows:
Total MEMORY difference: 298740644 / 298044996
Total CPU difference: 11593.640625 / 11626.8125

There are not serious differences in images found by testdiff.

07Commenter 7
Inserted TODO strings into test cases "did 010 C6" and "xsat 101 G6"
08Commenter 8
Dear BugMaster,
test cases "did 010 C6" and "xsat 101 G6" will be corrected afther pushing this fix to git repository.

Related records