Archived issue #0023634
Eliminate Polyline and Polygon usage in drawers
Description
Polyline and Polygon primitives should be replaced within primitive arrays
as Graphic3d_GraphicDriver::Polyline() and Graphic3d_GraphicDriver::Polygon() were deprecated and will be removed.
as Graphic3d_GraphicDriver::Polyline() and Graphic3d_GraphicDriver::Polygon() were deprecated and will be removed.
Public activity
10 archived notes
Participants are labeled by their role within this record.
The subset of #0023117 patch was re-based and pushed into CR23634 branch.
Please test it for regressions.
Please test it for regressions.
Dear Commenter 1,
Branch CR23634 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.
http://occt-tests/CR23634-master-occt/Mandriva2010/3rdparty/export/A7.html
Regressions/Improvements:
3rdparty export(001) A7 - Export to PGF file was done but file has a different size
Testing cases:
Not needed
Branch CR23634 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.
http://occt-tests/CR23634-master-occt/Mandriva2010/3rdparty/export/A7.html
Regressions/Improvements:
3rdparty export(001) A7 - Export to PGF file was done but file has a different size
Testing cases:
Not needed
Dear mkv,
Have you checked the exported file contents?
If it is correct, please update the reference file. The file size could have changed because now different primitive types are used by the test case - see the bug's title, it contains a hint.
Have you checked the exported file contents?
If it is correct, please update the reference file. The file size could have changed because now different primitive types are used by the test case - see the bug's title, it contains a hint.
Dear san,
I checked the exported file contents only by the length (see test case).
png file of this test case was checked by visualisation in the viewer (GIMP), it is correct.
Test case 3rdparty export(001) A7 was corrected.
I checked the exported file contents only by the length (see test case).
png file of this test case was checked by visualisation in the viewer (GIMP), it is correct.
Test case 3rdparty export(001) A7 was corrected.
Dear mkv,
It is not necessary to check the PNG snapshot.
The given test case checks if PGF export works as expected.
Since PGF is a part of TEX specification, checking the visual results requires generation of some target format (PDF or PS) from the TEX document.
Thus probably it is enough to compare the new PGF output with the reference one line-by-line and see if the differences are reasonable or not.
It is not necessary to check the PNG snapshot.
The given test case checks if PGF export works as expected.
Since PGF is a part of TEX specification, checking the visual results requires generation of some target format (PDF or PS) from the TEX document.
Thus probably it is enough to compare the new PGF output with the reference one line-by-line and see if the differences are reasonable or not.
Reminder sent to: mkv
Dear mkv,
Could you please attach the old and new PGF output to this issue so that we could analyze the differences?
Dear mkv,
Could you please attach the old and new PGF output to this issue so that we could analyze the differences?
Dear san,
Attachment 2 (PGF) - old pgf file;
Attachment 1 (PGF) - pgf file of this fix.
Attachment 2 (PGF) - old pgf file;
Attachment 1 (PGF) - pgf file of this fix.
Dear kgv,
Could you please review the differences between the two PGF export output files attached?
Could you please review the differences between the two PGF export output files attached?
Technically there no differences between files - one of them contains some segments split into 2 halves.
Please proceed with the patch integration ASAP.
Related records