Archived issue #0023696

Restore work of draw function nexplode for degenerated edges

Open CASCADEOCCT:DRAWassigned8 public notes

Search issues

Description

Restore the work after changes of BRepGProp::LinearProperties method by CR23610.

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 1
The work was restored in case of exploding by edges.
Review it please.
02Commenter 2
Please rebase this fix on current master keeping only relevant changes (now CR23696 has common commits with CR23610_2)
03Commenter 3
The fix was pushed to branch CR23696_2.
Review it please.
04Commenter 4
I suggest using method of BRep_Tool class to get point of the vertex and degenerated flag of the edge, instead of direct casts to TVertex and TEdge. As well, rebase on current master is needed (sorry for late review!).
05Commenter 5
Access to vertex 3D point and edge degenerated flag was made through class BRep_Tool.

The fix was rebased on current master in branch CR23696_3.
06Commenter 6
Please review the fix.
07Commenter 7
No remarks, please test
08Commenter 8
Dear Commenter 1,

Branch CR23696_3 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)

Regressions:
http://occt-tests/CR23696-3-master-occt/Mandriva2010/summary.html
http://occt-tests/CR23696-3-master-occt/Windows-32-VC9/summary.html
blend complex(006) C4 C7
blend simple(001) Y9
boolean bcut_complex(012) O8
bugs modalg_2(007) bug23174
feat featrf(005) A8

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 243119520 / 243310832
Total CPU difference: 18046.570000000167 / 15452.240000000038

Testing on Windows:
Total MEMORY difference: 345971936 / 345982332
Total CPU difference: 17307.078125 / 21461.625

There are not serious differences in images found by testdiff.
http://occt-tests/CR23696-3-master-occt/Windows-32-VC9/diff-Windows-32-VC9.html
http://occt-tests/CR23696-3-master-occt/Mandriva2010/diff-Mandriva2010.html
IMAGE feat featrf A4: A4.png differs
IMAGE feat featrf A5: A5.png differs
IMAGE feat featrf A6: A6.png differs
IMAGE feat featrf B4: B4.png differs
IMAGE blend complex C3: C3.png differs
IMAGE blend complex C8: C8.png differs
IMAGE blend complex C9: C9.png differs
IMAGE blend complex D9: D9.png differs
IMAGE blend simple K3: K3.png differs
IMAGE blend simple T7: T7.png differs
IMAGE blend buildevol F8: F8.png differs
IMAGE blend buildevol J8: J8.png differs
IMAGE draft angle F1: F1.png differs

Related records