Archived issue #0023787
Eliminate trivial type conversion warnings in MSVC
Description
OCCT code still has about 35 compiler warnings reported by MSVC++ 9.0 on casting of double to float, long to int etc., which can be easily eliminated
Public activity
3 archived notes
Participants are labeled by their role within this record.
Most of remaining warnings of MS VC++ 9.0 in 32 bit mode corrected, please review
Patch was reviewed without remarks.
Dear Commenter 2,
Branch CR23787 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 3 (3 on master)
Windows: 12 (39 on master)
products component :
Linux: 9 (9 on master)
Windows: 50 (50 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 239728052 / 239606140
Total CPU difference: 27091.990000000027 / 16161.8599999998
Testing on Windows:
Total MEMORY difference: 343528848 / 343545904
Total CPU difference: 17490.09375 / 16749.0
There are not serious differences in images found by testdiff.
Branch CR23787 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 3 (3 on master)
Windows: 12 (39 on master)
products component :
Linux: 9 (9 on master)
Windows: 50 (50 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 239728052 / 239606140
Total CPU difference: 27091.990000000027 / 16161.8599999998
Testing on Windows:
Total MEMORY difference: 343528848 / 343545904
Total CPU difference: 17490.09375 / 16749.0
There are not serious differences in images found by testdiff.