DiscussionsIssue archiveOCCT:Foundation Classes

Archived issue #0023852

OSD_Path interprets unc paths incorrectly

Open CASCADEOCCT:Foundation Classesclosed6 public notes

Search issues

Description

Function RemoveExtraSeparator(TCollection_AsciiString& aString) replaces all consecutive forward slashes to one forward slash, it leads to impossibility of using unc paths.

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Author
Checking for unc paths on Windows was added.

Branch CR23852 is ready to be reviewed.

Dear GKA,
Please review.
02Commenter 2
Dear ika,

please avoid using deprecated macro WNT. Use _WIN32 instead (in this case).
03Author
Dear KGV,
Thank you for your remark, branch CR23852 was updated.
04Commenter 4
Branch CR23852 is ready to test
05Author
Dear MKV,
command OSDPath works with unc path correctly

Draw[22]> OSDPath //VIRTEX/dn43/occt_tests_data/public/step/trj4_xr1-db-214.stp
Node :
UserName :
Password :
Disk :
Trek : ||VIRTEX|dn43|occt_tests_data|public|step|
Name : trj4_xr1-db-214
Extension : .stp
06Commenter 6
Dear Commenter 1,

Branch CR23852 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
bugs fclasses bug23852 - OK.

Testing on Linux:
Total MEMORY difference: 226881916 / 225185580
Total CPU difference: 15027.550000000436 / 15162.959999999912

Testing on Windows:
Total MEMORY difference: 353186568 / 355405792
Total CPU difference: 21115.59375 / 21156.953125

There are not serious differences in images found by testdiff.