Archived issue #0023966
Voxel_FastConverter performs unnecessary triangulation.
Description
In line 126:
if (T.IsNull() || fabs(T->Deflection() - myDeflection) > Precision::Confusion())
the triangulation will be recomputed even if its finer then the existing one. In my opinion this should be changed to:
if (T.IsNull() || T->Deflection() > myDeflection > Precision::Confusion())
This is similar to usage in other cases in OCCT (see BRepTools::Triangulation).
In case there is a solution to the issue 23200, it should also be used at this place.
if (T.IsNull() || fabs(T->Deflection() - myDeflection) > Precision::Confusion())
the triangulation will be recomputed even if its finer then the existing one. In my opinion this should be changed to:
if (T.IsNull() || T->Deflection() > myDeflection > Precision::Confusion())
This is similar to usage in other cases in OCCT (see BRepTools::Triangulation).
In case there is a solution to the issue 23200, it should also be used at this place.
Public activity
5 archived notes
Participants are labeled by their role within this record.
Branch CR23966 pushed. Please review.
Vlad,
please make reviewing
please make reviewing
Well done!
Reviewed!
Dear Commenter 1,
Branch CR23966 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)
products component :
Linux: 0 (0 on master)
Windows: 64 (64 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 365910752 / 365861168
Total CPU difference: 45078.63000000133 / 45787.35000000135
Testing on Windows:
Total MEMORY difference: 418378676 / 420890384
Total CPU difference: 29629.6875 / 30778.828125
There are not differences in images found by testdiff.
Branch CR23966 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)
products component :
Linux: 0 (0 on master)
Windows: 64 (64 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 365910752 / 365861168
Total CPU difference: 45078.63000000133 / 45787.35000000135
Testing on Windows:
Total MEMORY difference: 418378676 / 420890384
Total CPU difference: 29629.6875 / 30778.828125
There are not differences in images found by testdiff.
Related records