Archived issue #0024018
Voxel_FastConverter::Convert - avoiding unnecessary iterations when using multiple threads
Description
The line:
if (ithread_triangle < start_thread_triangle || ithread_triangle > end_thread_triangle)
continue;
continues iteration even when ithread_triangle > end_thread_triangle. This is not necessary and can be avoided. The iterations should be ended.
if (ithread_triangle < start_thread_triangle || ithread_triangle > end_thread_triangle)
continue;
continues iteration even when ithread_triangle > end_thread_triangle. This is not necessary and can be avoided. The iterations should be ended.
Public activity
3 archived notes
Participants are labeled by their role within this record.
Branch CR24018 pushed and ready to review.
Reviewed!
Dear Commenter 2,
Branch CR24018 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 2 (2 on master)
Windows: 7 (7 on master)
products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 366354096 / 366313324
Total CPU difference: 39932.66000000103 / 43688.52000000147
Testing on Windows:
Total MEMORY difference: 347174552 / 349211996
Total CPU difference: 32990.296875 / 28199.328125
There are not differences in images found by testdiff.
Branch CR24018 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 2 (2 on master)
Windows: 7 (7 on master)
products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 366354096 / 366313324
Total CPU difference: 39932.66000000103 / 43688.52000000147
Testing on Windows:
Total MEMORY difference: 347174552 / 349211996
Total CPU difference: 32990.296875 / 28199.328125
There are not differences in images found by testdiff.