OCCT3D
DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0024083

BRepCheck_Wire crashes processing a wire consisting of many edges

Open CASCADEOCCT:Modeling Algorithmsclosed5 public notes

Search issues

Description

The attached wire consists of 100 000 linear edges. The class BRepCheck_Wire failes to analyse the wire.

Steps to reproduce

#Load the attached wire.
restore polyline.brep s
#Call BRepCheck_Wire to check validity of the wire.
checkshape s

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Author
Dear Ifv,
Review please my modification. I replaced a recursive method Propagate() in the class BRepCheck_Wire by a non-recursive method.
Non-regression tests passed well.
Thanks,
Vro
02Commenter 2
Ok
03Commenter 3
Branch CR24083 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 923 (917 on master)
Windows: 862 (855 on master)

products component :
Linux: 190 (188 on master)
Windows: 287 (287 on master)

Regressions:
http://occt-tests/CR24083-master-occt/Debian60-64/bugs/modalg_2/bug307_1.html
http://occt-tests/CR24083-master-occt/Debian60-64/bugs/modalg_2/bug307_2.html
http://occt-tests/CR24083-master-occt/Windows-32-VC9/bugs/modalg_2/bug307_1.html
http://occt-tests/CR24083-master-occt/Windows-32-VC9/bugs/modalg_2/bug307_2.html
bugs modalg_2(007) bug307_1, bug307_2 - BAD.

Improvements:
No improvements

Testing cases:
bugs modalg_5(010) bug24083: OK

Testing on Linux:
Total MEMORY difference: 363467472 / 363206424
Total CPU difference: 55842.140000000836 / 49185.290000000496

Testing on Windows:
Total MEMORY difference: 424310136 / 424079384
Total CPU difference: 38489.703125 / 32931.203125

There are not differences in images found by testdiff.
04Author
Corrected. Same branch: [archived branch]
05Commenter 5
Dear Commenter 1,

Branch CR24083 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 916 (917 on master)
Windows: 855 (855 on master)

products component :
Linux: 188 (188 on master)
Windows: 287 (287 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
bugs modalg_5(010) bug24083: OK

Testing on Linux:
Total MEMORY difference: 363647304 / 363272428
Total CPU difference: 44620.65000000041 / 49185.7300000005

Testing on Windows:
Total MEMORY difference: 421950984 / 421870816
Total CPU difference: 39707.34375 / 31550.171875

There are not differences in images found by testdiff.