Archived issue #0024132
Test execution fails due to permission rights issues
Description
Current implementation of capture_start() has 2 issues - tmpfile() return values is ignored and this function is irrelevant on modern systems according to MSDN documentation because temporary file is created in root directory of current drive.
Public activity
4 archived notes
Participants are labeled by their role within this record.
The initial patch has been pushed into CR24132 branch.
However current _tempnam() implementation seems to be very trivial (using of internal counter) and may lead to file open failure on concurrent calls.
However current _tempnam() implementation seems to be very trivial (using of internal counter) and may lead to file open failure on concurrent calls.
I have improved the patch by adding: PID to name prefix, path to directory indicated by env. var. TEMP as location where file can be created, removing temp files, handling of possible errors. Please review
Patch has been reviewed with minor remark (redundant typecast (int)OSD_Process().ProcessId()).
Please perform testing.
Please perform testing.
Dear Commenter 1,
Branch CR24132 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 781 (781 on master)
Windows: 386 (386 on master)
products component :
Linux: 188 (191 on master)
Windows: 287 (287 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 365699764 / 365366360
Total CPU difference: 41765.760000000984 / 54103.98000000012
Testing on Windows:
Total MEMORY difference: 428685728 / 429434700
Total CPU difference: 35087.171875 / 36525.203125
There are not differences in images found by testdiff.
Branch CR24132 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 781 (781 on master)
Windows: 386 (386 on master)
products component :
Linux: 188 (191 on master)
Windows: 287 (287 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 365699764 / 365366360
Total CPU difference: 41765.760000000984 / 54103.98000000012
Testing on Windows:
Total MEMORY difference: 428685728 / 429434700
Total CPU difference: 35087.171875 / 36525.203125
There are not differences in images found by testdiff.