Archived issue #0024293
Dimension flyout lines don't belong to the dimension sensitive entity.
Description
In default selection mode dimension flyout lines should be a part of the dimension sensitive entity. Now they are not selectable, they are only highlighted in default selection mode, when another part of dimension is detected.
Additional information
Changes:
Computing of selection for dimensions has been changed. In the base class AIS_Dimension computeFlyoutSelection () has been added to add flyout sensitive in the default selection mode. This method has been overwritten for AIS_AngleDimension to provide selection of specific flyout lines.
In this scope flyout field has been moved to AIS_Dimension as common for all dimensions property.
Test case was added to check if flyout lines of length dimension are selectable.
Computing of selection for dimensions has been changed. In the base class AIS_Dimension computeFlyoutSelection () has been added to add flyout sensitive in the default selection mode. This method has been overwritten for AIS_AngleDimension to provide selection of specific flyout lines.
In this scope flyout field has been moved to AIS_Dimension as common for all dimensions property.
Test case was added to check if flyout lines of length dimension are selectable.
Public activity
8 archived notes
Participants are labeled by their role within this record.
The branch CR24293 contains modification of dimension classes to add flyouts to dimension sensitive entity.
Dear apl, please review.
Dear apl, please review.
Dear Commenter 1,
The branch is reviewed.
Please test.
The branch is reviewed.
Please test.
Dear Commenter 1,
Branch CR24293 (and products from GIT master) was compiled on Linux and Windows platforms.
[revision removed]
There are compilation errors on Linux platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24293/job/mnt-CR24293-master_build_occt_linux/1/parsed_console/?
../../../../src/AIS/AIS_AngleDimension.cxx: In constructor ‘AIS_AngleDimension::AIS_AngleDimension(const TopoDS_Edge&, const TopoDS_Edge&, const gp_Pln&, const Handle_Prs3d_DimensionAspect&, Standard_Real)’:
../../../../src/AIS/AIS_AngleDimension.cxx:176: error: expected ‘{’ before ‘myShapesNumber’
../../../../src/AIS/AIS_AngleDimension.cxx: At global scope:
../../../../src/AIS/AIS_AngleDimension.cxx:176: error: expected constructor, destructor, or type conversion before ‘=’ token
../../../../src/AIS/AIS_AngleDimension.cxx:177: error: expected constructor, destructor, or type conversion before ‘=’ token
../../../../src/AIS/AIS_AngleDimension.cxx:178: error: expected constructor, destructor, or type conversion before ‘=’ token
../../../../src/AIS/AIS_AngleDimension.cxx:179: error: expected constructor, destructor, or type conversion before ‘(’ token
../../../../src/AIS/AIS_AngleDimension.cxx:180: error: expected declaration before ‘}’ token
There is compilation error on Windows platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24293/job/mnt-CR24293-master_build_occt_windows/1/parsed_console/?
34>..\..\..\src\AIS\AIS_AngleDimension.cxx(229) : error C2059: syntax error : '{'
Branch CR24293 (and products from GIT master) was compiled on Linux and Windows platforms.
[revision removed]
There are compilation errors on Linux platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24293/job/mnt-CR24293-master_build_occt_linux/1/parsed_console/?
../../../../src/AIS/AIS_AngleDimension.cxx: In constructor ‘AIS_AngleDimension::AIS_AngleDimension(const TopoDS_Edge&, const TopoDS_Edge&, const gp_Pln&, const Handle_Prs3d_DimensionAspect&, Standard_Real)’:
../../../../src/AIS/AIS_AngleDimension.cxx:176: error: expected ‘{’ before ‘myShapesNumber’
../../../../src/AIS/AIS_AngleDimension.cxx: At global scope:
../../../../src/AIS/AIS_AngleDimension.cxx:176: error: expected constructor, destructor, or type conversion before ‘=’ token
../../../../src/AIS/AIS_AngleDimension.cxx:177: error: expected constructor, destructor, or type conversion before ‘=’ token
../../../../src/AIS/AIS_AngleDimension.cxx:178: error: expected constructor, destructor, or type conversion before ‘=’ token
../../../../src/AIS/AIS_AngleDimension.cxx:179: error: expected constructor, destructor, or type conversion before ‘(’ token
../../../../src/AIS/AIS_AngleDimension.cxx:180: error: expected declaration before ‘}’ token
There is compilation error on Windows platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24293/job/mnt-CR24293-master_build_occt_windows/1/parsed_console/?
34>..\..\..\src\AIS\AIS_AngleDimension.cxx(229) : error C2059: syntax error : '{'
Compilation errors were fixed.
Dear mkv, please retest.
Dear mkv, please retest.
Dear Commenter 1,
Branch CR24293 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 318 (318 on master)
Windows: 0 (0 on master)
products component :
Linux: 188 (188 on master)
Windows: 287 (287 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
http://occt-tests/CR24293-0-master-occt/Debian60-64/bugs/vis/bug24293.html
http://occt-tests/CR24293-0-master-occt/Windows-32-VC9/bugs/vis/bug24293.html
bugs vis(004) bug24293: OK
Testing on Linux:
Total MEMORY difference: 356584804 / 356528104
Total CPU difference: 43352.48000000008 / 42450.130000000434
Testing on Windows:
Total MEMORY difference: 411756980 / 410771744
Total CPU difference: 30270.59375 / 30177.609375
There are not differences in images found by testdiff.
Branch CR24293 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 318 (318 on master)
Windows: 0 (0 on master)
products component :
Linux: 188 (188 on master)
Windows: 287 (287 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
http://occt-tests/CR24293-0-master-occt/Debian60-64/bugs/vis/bug24293.html
http://occt-tests/CR24293-0-master-occt/Windows-32-VC9/bugs/vis/bug24293.html
bugs vis(004) bug24293: OK
Testing on Linux:
Total MEMORY difference: 356584804 / 356528104
Total CPU difference: 43352.48000000008 / 42450.130000000434
Testing on Windows:
Total MEMORY difference: 411756980 / 410771744
Total CPU difference: 30270.59375 / 30177.609375
There are not differences in images found by testdiff.
Dear apl,
could you pleas revise result of bugs vis(004) bug24293
could you pleas revise result of bugs vis(004) bug24293
Dear mkv,
The results are OK.
All of the dimension lines are sensitive to selection and highlighted properly.
The results are OK.
All of the dimension lines are sensitive to selection and highlighted properly.
OK.
CR24293 is TESTED.
CR24293 is TESTED.
Related records