DiscussionsIssue archiveOCCT:Foundation Classes

Archived issue #0024296

Foundation Classes - Test "bugs fclasses bug309" is crashed if current directory is into disc-root

Open CASCADEOCCT:Foundation Classesassigned16 public notes

Search issues

Description

If current directory is into disc-root, we have following result:
    ...
    OCC309
    *D://CurDir*
    *D://CurDir*

    result1 = *D://CurDir*
    res1 = //CurDir
    CurrentDirectory = /CurDir
    OCC309: Error 1
    ...

Otherwise:
    ...
    OCC309
    *d:/tests_group/bugs/tests_subgroup/002*
    *d:/tests_group/bugs/002*

    OCC309: OK 1
    ...

Steps to reproduce

test bugs fclasses bug309

Public activity

16 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been deleted by Commenter 2.

[revision removed]
02Commenter 1
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: ski
Date: Fri Sep 23 17:06:12 2016 +0300

    0024296: Test "bugs fclasses bug309" is crashed if current directory is into disc-root
    
    Fixed incorrect inclusion of slash symbol to the path.
03Commenter 3
Dear abv,

please review.
04Commenter 4
This change is unsafe: j can be equal to 1, in this case trek[j-2] will address memory belonging to some other variable. Please add check for j to be at least 2.

In addition, please remove "static" in declaration of "trek" variable, to avoid possibility of having data races at this point in case of multithreaded execution.
05Commenter 1
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
06Commenter 6
Done.
07Commenter 7
No remarks, please test
08Commenter 1
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
09Commenter 9
Branch CR24296 from occt git-repository has been rebased on the current master.
10Commenter 10
Dear BugMaster,

Branch CR24296 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1140

Regressions/Differences:
http://occt-tests/CR24296-master-OCCT/Debian70-64/summary.html
bugs fclasses bug309 (Linux only)

Testing on Linux:
Total MEMORY difference: 91216076 / 90243851 [+1.08%]
Total CPU difference: 19507.02999999999 / 19251.91999999988 [+1.33%]

Testing on Windows:
Total MEMORY difference: 57203803 / 57221541 [-0.03%]
Total CPU difference: 17904.889974198697 / 18310.78897609872 [-2.22%]
11Commenter 11
Dear Sergey,

Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
12Commenter 1
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: ski
Date: Wed Sep 28 18:09:28 2016 +0300

    Removed unnecessary slash at the end of path returned by method CurrentDirectory of OSD_Process class

13Commenter 13
On current master method CurrentDirectory of OSD_Process class returns path in kind of "/Directory/Subdir1/CurrentProcessDir/" on linux platform.
On windows platform it returns "/Directory/Subdir1/CurrentProcessDir" (without ending slash)

I think that it should return "/Directory/Subdir1/CurrentProcessDir" on both platform (For example command "pwd" returns path without ending slash on Linux)

Dear abv,
i have pushed changes in last commit of branch CR24296.

14Commenter 1
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: ski
Date: Thu Sep 29 19:08:20 2016 +0300

    Added test case.

Author: ski
Date: Wed Sep 28 18:09:28 2016 +0300

    Removed unnecessary slash at the end of path returned by method CurrentDirectory of OSD_Process class

Author: ski
Date: Fri Sep 23 17:06:12 2016 +0300

    0024296: Test "bugs fclasses bug309" is crashed if current directory is into disc-root
    
    Fixed incorrect inclusion of slash symbol to the path.
15Commenter 1
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
16Commenter 1
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Related records