Archived issue #0024355
Compiler Warning level 4 for MFC samples
Description
All Visual Studio projects of MFC samples are required to be updated:
1. change compiler warning level: 4 level is required
2. fixed all warnings within projects that appeared after compiler warning level changing
1. change compiler warning level: 4 level is required
2. fixed all warnings within projects that appeared after compiler warning level changing
Steps to reproduce
folders of projects of all versions:
<occt root>/samples/mfc/standard/<sample name>/adm/win/vc8
vc9
vc10
vc11
<occt root>/samples/mfc/standard/<sample name>/adm/win/vc8
vc9
vc10
vc11
Public activity
7 archived notes
Participants are labeled by their role within this record.
some warnings have been removed; changes have been committed to CR24355 branch
Level 4 warnings of sample projects were fixed on VC9.
Changes are located in branch CR24355.
Please, review.
Changes are located in branch CR24355.
Please, review.
Changes in samples/mfc/standard/03_Viewer2d/src/Viewer2dDoc.cpp and samples/mfc/standard/06_Ocaf/src/OcafDoc.cpp actually disable part of functionality (reading files), please restore.
Warnings related to passing reference to temporary objects could better be eliminated by appropriate change of the parameter of the relevant methods (make reference "const"). Methods SetTitle() and SetText() in dialog classes can be complemented by variants accepting C string, this would allow passing string literals "as is", without any conversions.
Note that I pushed one more commit in this branch enabling warning lever W4 in all VS projects of MFC samples, and adding Readme on samples to OCCT docs.
Warnings related to passing reference to temporary objects could better be eliminated by appropriate change of the parameter of the relevant methods (make reference "const"). Methods SetTitle() and SetText() in dialog classes can be complemented by variants accepting C string, this would allow passing string literals "as is", without any conversions.
Note that I pushed one more commit in this branch enabling warning lever W4 in all VS projects of MFC samples, and adding Readme on samples to OCCT docs.
>Changes in samples/mfc/standard/03_Viewer2d/src/Viewer2dDoc.cpp
>samples/mfc/standard/06_Ocaf/src/OcafDoc.cpp
my bad...
>samples/mfc/standard/06_Ocaf/src/OcafDoc.cpp
my bad...
Remarks were applied.
Changes are located in branch CR24355.
Please, review.
Changes are located in branch CR24355.
Please, review.
Well done! no remarks, please test
There are no warnings in MFC samples in all versions (vc8 vc9 vc10 vc11). Samples work correctly.
Related records