Archived issue #0024388
Option to enable visualization of hidden lines in DRAW
Description
Currently, there is no way to enable visualization of hidden lines in DRAW.
Meanwhile, both HLR algorithms (StdPrs_HLRPolyShape and StdPrs_HLRShape) support this.
It is proposed to add an option to vhlr or vhlrtype command to show hidden lines, and to improve the test cases related to HLR accordingly.
Meanwhile, both HLR algorithms (StdPrs_HLRPolyShape and StdPrs_HLRShape) support this.
It is proposed to add an option to vhlr or vhlrtype command to show hidden lines, and to improve the test cases related to HLR accordingly.
Public activity
5 archived notes
Participants are labeled by their role within this record.
The git branch CR24388 is ready to be reviewed.
1) The option to draw hidden lines was added to vhlr command
2) Test cases /bugs/vis/bug24388_1 and /bugs/vis/bug24388_2 were added to test hidden lines displaying.
Dear san,
please review.
1) The option to draw hidden lines was added to vhlr command
2) Test cases /bugs/vis/bug24388_1 and /bugs/vis/bug24388_2 were added to test hidden lines displaying.
Dear san,
please review.
Branch CR24388 reviewed with the following remarks:
src/ViewerTest/ViewerTest_ViewerCommands.cxx: VHLR() function - enabling/disabling the computed mode should be moved to the beginning of the function. Currently, checking PREVIOUS value of MyHLRIsOn variable and settings the NEW value few lines after that looks confusing.
The test cases: is it really important to have two test cases for highlighting of HLR'ed presentation? Is it possible to check regular HLR visualization in one of the cases? And once a test case includes several stages and result of each stage is checked, it is recommended to dump 3D view snapshot several times, just to be able to check visually what was wrong with the case.
src/ViewerTest/ViewerTest_ViewerCommands.cxx: VHLR() function - enabling/disabling the computed mode should be moved to the beginning of the function. Currently, checking PREVIOUS value of MyHLRIsOn variable and settings the NEW value few lines after that looks confusing.
The test cases: is it really important to have two test cases for highlighting of HLR'ed presentation? Is it possible to check regular HLR visualization in one of the cases? And once a test case includes several stages and result of each stage is checked, it is recommended to dump 3D view snapshot several times, just to be able to check visually what was wrong with the case.
Branch CR24388 was corrected according to remarks.
Dear san,
please review.
Dear san,
please review.
Branch CR24388 reviewed without remarks, ready for testing.
Dear Commenter 1,
Branch CR24388 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 55 (55 on master)
Windows: 1 (1 on master)
products component :
Linux: 20 (20 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
http://occt-tests/CR24388-master-occt/Debian60-64/bugs/vis/bug24388_1.html
http://occt-tests/CR24388-master-occt/Windows-32-VC9/bugs/vis/bug24388_1.html
bugs vis(004) bug24388_1: OK
http://occt-tests/CR24388-master-occt/Debian60-64/bugs/vis/bug24388_2.html
http://occt-tests/CR24388-master-occt/Windows-32-VC9/bugs/vis/bug24388_2.html
bugs vis(004) bug24388_2: OK
Testing on Linux:
Total MEMORY difference: 357927760 / 357072716
Total CPU difference: 44640.649999999914 / 42990.47999999986
Testing on Windows:
Total MEMORY difference: 413251036 / 412474228
Total CPU difference: 29806.625 / 32601.09375
There are not differences in images found by testdiff.
Branch CR24388 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 55 (55 on master)
Windows: 1 (1 on master)
products component :
Linux: 20 (20 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
http://occt-tests/CR24388-master-occt/Debian60-64/bugs/vis/bug24388_1.html
http://occt-tests/CR24388-master-occt/Windows-32-VC9/bugs/vis/bug24388_1.html
bugs vis(004) bug24388_1: OK
http://occt-tests/CR24388-master-occt/Debian60-64/bugs/vis/bug24388_2.html
http://occt-tests/CR24388-master-occt/Windows-32-VC9/bugs/vis/bug24388_2.html
bugs vis(004) bug24388_2: OK
Testing on Linux:
Total MEMORY difference: 357927760 / 357072716
Total CPU difference: 44640.649999999914 / 42990.47999999986
Testing on Windows:
Total MEMORY difference: 413251036 / 412474228
Total CPU difference: 29806.625 / 32601.09375
There are not differences in images found by testdiff.
Related records