Archived issue #0024447

Includes of ixx and jxx files should be replaced by their content

Open CASCADEOCCT:Codingclosed11 public notes

Search issues

Description

Includes of ixx and jxx files should be replaced by their content in "src" directory.

Steps to reproduce

N/A

Public activity

11 archived notes

Participants are labeled by their role within this record.

01Commenter 1
In general the change looks fine, however I still have some remarks to be accounted for:

1. Macros like DEFINE_STANDARD_RTTI should be reduced (for that WOK should be modified) to use simplified syntax

2. These macros should be put after all #includes

3. Duplicated #includes should be checked and removed

This is not urgent, so let's postpone this. To save current results, please attach the script you have made, to this issue.

02Commenter 2
File "Attachment 1 (PY)" was attached.
It contains the script i have made, to this issue.
For information:
- Script should be placed at the folder with occt.
- Main function is start(folder_name = "occt"), where "folder_name" is the name of folder with occt.
- Line 98 is commented to prevent changes in files, to save changes - uncomment it.
03Commenter 3
Please consider integrating procedure of update of sources to remove IXX and JXX classes to the Tcl script I have started in branch CR24750.
04Commenter 4
The last version of changes is located in branch CR24447_1.
05Commenter 5
New version of changes is located in branch CR24447_2.
In this branch includes of windows.h were remained on their place in code.
06Commenter 6
Fixed in current master
07Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
08Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
09Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
10Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
11Commenter 3
Branch [archived branch] has been deleted by Commenter 4.

[revision removed]

Related records