Archived issue #0024451
Logical conjunction always evaluates to false
Description
In DDataStd_BasicCommands.cxx on line 1156:
if(ival < 0 && 255 < ival) {
Probably it should read:
if(ival < 0 || 255 < ival) {
if(ival < 0 && 255 < ival) {
Probably it should read:
if(ival < 0 || 255 < ival) {
Public activity
3 archived notes
Participants are labeled by their role within this record.
Branch CR24451 pushed. Please review.
No remarks, please test
Dear Commenter 2,
Branch CR24451 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 103 (103 on master)
Windows: 0 (0 on master)
products component :
Linux: 21 (21 on master)
Windows: 8 (8 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 357313572 / 358871012
Total CPU difference: 41840.76000000025 / 67594.04000000008
Testing on Windows:
Total MEMORY difference: 413301512 / 413246736
Total CPU difference: 30789.6875 / 30600.03125
There are not differences in images found by testdiff.
Branch CR24451 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 103 (103 on master)
Windows: 0 (0 on master)
products component :
Linux: 21 (21 on master)
Windows: 8 (8 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 357313572 / 358871012
Total CPU difference: 41840.76000000025 / 67594.04000000008
Testing on Windows:
Total MEMORY difference: 413301512 / 413246736
Total CPU difference: 30789.6875 / 30600.03125
There are not differences in images found by testdiff.