Archived issue #0024530
TKMesh - remove unused package IntPoly
Description
Package IntPoly (included in TKMesh toolkit) seems to be never used and looks meaningless. Its purpose seems to be building intersection of two shapes or shape and plane using shape triangulation, which is likely available in other places. The code had no changes since its creation in 1995. I propose it should be removed.
Public activity
12 archived notes
Participants are labeled by their role within this record.
Igor, please give your opinion on this (do you know if any project used this package?)
I know nothing about using IntPoly in any projects, but as far as I know similar functionality - intersection of triangulations - sometimes is requested.
If we have similar functionality, may be it is worth to update package by new algorithms?
If we have similar functionality, may be it is worth to update package by new algorithms?
This functionality is repeated in OMF:
IntPoly_PlaneSection => OMFAlgo_PlaneIntersect
IntPoly_ShapeSection => OMFAlgo_MeshIntersect
IntPoly works with Poly_Triangulation, OMFAlgo works with OMFDS_Mesh.
I do not think that maintaining both is a good idea.
Since at least OMFAlgo_MeshIntersect is used by OMF Boolean Operations, it follows that IntPoly package could be removed.
IntPoly_PlaneSection => OMFAlgo_PlaneIntersect
IntPoly_ShapeSection => OMFAlgo_MeshIntersect
IntPoly works with Poly_Triangulation, OMFAlgo works with OMFDS_Mesh.
I do not think that maintaining both is a good idea.
Since at least OMFAlgo_MeshIntersect is used by OMF Boolean Operations, it follows that IntPoly package could be removed.
I agree with SZV
DC,
This package used in MeshTest/MeshTest.cxx file. If we want to use OMFAlgo instead of IntPoly, it should be included in OCCT deployment, but now i can't find it.
This package used in MeshTest/MeshTest.cxx file. If we want to use OMFAlgo instead of IntPoly, it should be included in OCCT deployment, but now i can't find it.
MeshTest is just a test tool for OCCT; testing useless functionality is senseless thus relevant commands from MeshTest should be simply removed. Please check if these commands are used in some tests.
Relevant commands not used in tests. Since that, branch CR24530 ready for review.
OK
Dear aml,
the first commit in patch should start from bug title "0024530: TKMesh - remove unused package IntPoly".
It is not enough to remove files in IntPoly folder - all references should be cleaned up as well, including src/TKMesh/PACKAGES and adm/UDLIST.
Please proceed.
the first commit in patch should start from bug title "0024530: TKMesh - remove unused package IntPoly".
It is not enough to remove files in IntPoly folder - all references should be cleaned up as well, including src/TKMesh/PACKAGES and adm/UDLIST.
Please proceed.
Dear ifv,
Please review branch CR24530.
Please review branch CR24530.
Ok
Dear BugMaster,
Branch CR24530 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 40 (40 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 380390912 / 381831144
Total CPU difference: 57369.31999999954 / 42213.76
Testing on Windows:
Total MEMORY difference: 428621768 / 431123492
Total CPU difference: 34287.90625 / 34130.65625
There are not differences in images found by testdiff.
Branch CR24530 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 40 (40 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 380390912 / 381831144
Total CPU difference: 57369.31999999954 / 42213.76
Testing on Windows:
Total MEMORY difference: 428621768 / 431123492
Total CPU difference: 34287.90625 / 34130.65625
There are not differences in images found by testdiff.