Archived issue #0024553
Deleting obsolete/unused ".gxx" files from "GCPnts"
Description
From "GCPnts" next ".gxx" files were removed:
- GCPnts_AbscissaPoint.gxx
- GCPnts_QuasiUniformAbscissa.gxx
- GCPnts_QuasiUniformDeflection.gxx
- GCPnts_TangentialDeflection.gxx
- GCPnts_UniformAbscissa.gxx
- GCPnts_UniformDeflection.gxx
Because their ".cxx" analogues are already exist.
- GCPnts_AbscissaPoint.gxx
- GCPnts_QuasiUniformAbscissa.gxx
- GCPnts_QuasiUniformDeflection.gxx
- GCPnts_TangentialDeflection.gxx
- GCPnts_UniformAbscissa.gxx
- GCPnts_UniformDeflection.gxx
Because their ".cxx" analogues are already exist.
Public activity
11 archived notes
Participants are labeled by their role within this record.
Changes are ready for review in CR24553 branch.
No remarks, please test
Wrong: these GXX files are used inside CXX files of the same package. That is, they cannot be simply removed.
Changes are ready for review in CR24553 branch.
What were done:
Next classes were converted to the template classes:
1) "GCPnts_QuasiUniformAbscissa"
2) "GCPnts_UniformAbscissa"
3) "GCPnts_AbscissaPoint"
4) "GCPnts_UniformDeflection"
5) "GCPnts_QuasiUniformDeflection"
And "GCPnts_TangentialDeflection" class was simplified to work only with 3D case. Also other changes were made in the other packages for correct compilation of the application.
What were done:
Next classes were converted to the template classes:
1) "GCPnts_QuasiUniformAbscissa"
2) "GCPnts_UniformAbscissa"
3) "GCPnts_AbscissaPoint"
4) "GCPnts_UniformDeflection"
5) "GCPnts_QuasiUniformDeflection"
And "GCPnts_TangentialDeflection" class was simplified to work only with 3D case. Also other changes were made in the other packages for correct compilation of the application.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: abv
Date: Fri Jun 17 11:36:49 2016 +0300
0024553: Deleting obsolete/unused ".gxx" files from "GCPnts"
Extension of files GXX is changed to "pxx" to avoid them to be copied to inc folder.
Code of inline functions contained in LXX files is merged to HXX files, LXX files are removed.
[revision removed]
Detailed log of new commits:
Author: abv
Date: Fri Jun 17 11:36:49 2016 +0300
0024553: Deleting obsolete/unused ".gxx" files from "GCPnts"
Extension of files GXX is changed to "pxx" to avoid them to be copied to inc folder.
Code of inline functions contained in LXX files is merged to HXX files, LXX files are removed.
There seem to be no good reason in conversing GXX files in GCPnts package to plain C++ templates. These files define "generic" code for implementation of methods of the package, each of them is included twice by corresponding CXX file to generate code for 3d and 2d curves.
Conversion of these files to true templates is troublesome due to need to specify multiple arguments of the template. In the version contained in branch CR24553, this makes their use really tricky. Providing more elaborate version seems to not make much sense since these templates are intended only for two variants (2d and 3d), and current implementation looks reasonable in this context.
Branch CR24553_1 simply renames these GXX files to PXX, so that they will not be copied to inc folder. Also, LXX files are removed (merged to HXX).
Please review.
Conversion of these files to true templates is troublesome due to need to specify multiple arguments of the template. In the version contained in branch CR24553, this makes their use really tricky. Providing more elaborate version seems to not make much sense since these templates are intended only for two variants (2d and 3d), and current implementation looks reasonable in this context.
Branch CR24553_1 simply renames these GXX files to PXX, so that they will not be copied to inc folder. Also, LXX files are removed (merged to HXX).
Please review.
Seems to be OK
Dear Commenter 1,
Branch CR24553_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 68 (68 on master)
Windows: 0 (0 on master)
MacOS : 1131
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 88745859 / 89153373 [-0.46%]
Total CPU difference: 19442.099999999937 / 19458.53999999997 [-0.08%]
products component :
Total MEMORY difference: 27241597 / 27412842 [-0.62%]
Total CPU difference: 5175.419999999984 / 5165.429999999985 [+0.19%]
Testing on Windows:
occt component :
Total MEMORY difference: 55900121 / 55903796 [-0.01%]
Total CPU difference: 18409.834010998835 / 18535.758018198954 [-0.68%]
products component :
Total MEMORY difference: 18650165 / 18614185 [+0.19%]
Total CPU difference: 5012.93613399995 / 4998.802443399952 [+0.28%]
There are no differences in images found by testdiff.
Branch CR24553_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 68 (68 on master)
Windows: 0 (0 on master)
MacOS : 1131
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 88745859 / 89153373 [-0.46%]
Total CPU difference: 19442.099999999937 / 19458.53999999997 [-0.08%]
products component :
Total MEMORY difference: 27241597 / 27412842 [-0.62%]
Total CPU difference: 5175.419999999984 / 5165.429999999985 [+0.19%]
Testing on Windows:
occt component :
Total MEMORY difference: 55900121 / 55903796 [-0.01%]
Total CPU difference: 18409.834010998835 / 18535.758018198954 [-0.68%]
products component :
Total MEMORY difference: 18650165 / 18614185 [+0.19%]
Total CPU difference: 5012.93613399995 / 4998.802443399952 [+0.28%]
There are no differences in images found by testdiff.
Dear Commenter 1,
Branch CR24553_1 is TESTED.
Branch CR24553_1 is TESTED.
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records