Archived issue #0024668
Null flyout value case in AIS_Dimension::SetTextPosition() method is not considered
Description
The null value of flyout in AIS_Dimension is not considered, but this case leads to exception in gp_Dir::IsOpposite() check for current flyout vector and positive flyout direction.
Public activity
4 archived notes
Participants are labeled by their role within this record.
The git branch CR24668 is ready to be reviewed.
Dear apl,
please review.
Dear apl,
please review.
Minor coding style remark was corrected in AIS_Dimension.cxx
Dear Commenter 1,
The branch is reviewed.
Please test.
The branch is reviewed.
Please test.
Dear Commenter 1,
Branch CR24668 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 30 (30 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 384635304 / 386276008
Total CPU difference: 56636.74000000014 / 48827.5
Testing on Windows:
Total MEMORY difference: 430631076 / 430913404
Total CPU difference: 34739.1875 / 35761.53125
There are no differences in images found by testdiff.
Branch CR24668 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 30 (30 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 384635304 / 386276008
Total CPU difference: 56636.74000000014 / 48827.5
Testing on Windows:
Total MEMORY difference: 430631076 / 430913404
Total CPU difference: 34739.1875 / 35761.53125
There are no differences in images found by testdiff.