Archived issue #0024710
Avoid including Handle_Class.hxx headers except where necessary
Description
In view of elimination of Handle_*.hxx header files "en masse" (see #0024709), we need to avoid including these headers except where actually necessary.
Public activity
5 archived notes
Participants are labeled by their role within this record.
The fix is pushed to branch CR24710 (containing also minor fix on new compiler warning), please review
Dear abv,
please confirm that the following change has been really intended:
please confirm that the following change has been really intended:
--- a/src/Standard/Standard_Transient.hxx +++ b/src/Standard/Standard_Transient.hxx @@ -16,7 +16,7 @@ #define _Standard_Transient_HeaderFile #ifndef _Handle_Standard_Transient_HeaderFile -#include <Handle_Standard_Transient.hxx> +#include <Standard_Transient.hxx> #endif
Oops, thank you for noticing! Now reverted, please check
Please test the patch.
Dear Commenter 1,
Branch CR24710 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 30 (30 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 385392684 / 385720176
Total CPU difference: 47852.20999999999 / 43631.789999999986
Testing on Windows:
Total MEMORY difference: 430798536 / 430805176
Total CPU difference: 32523.59375 / 30425.75
There are not differences in images found by testdiff.
Branch CR24710 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 30 (30 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 385392684 / 385720176
Total CPU difference: 47852.20999999999 / 43631.789999999986
Testing on Windows:
Total MEMORY difference: 430798536 / 430805176
Total CPU difference: 32523.59375 / 30425.75
There are not differences in images found by testdiff.
Related records