Archived issue #0024729

Duplicate code to compute the normals for TopoDS_Face

CommunityOCCT:Codingclosed2 public notes

Search issues

Description

There are duplicate code to compute the normals for the TopoDS_Face:
1. void StdPrs_ToolShadedShape::Normal (const TopoDS_Face& theFace,
                                     Poly_Connect& thePolyConnect,
                                     TColgp_Array1OfDir& theNormals)

2. In StlTransfer.cxx, also have the function to compute normals for surface:
   static void Normal(const TopoDS_Face& aFace,
           Poly_Connect& pc,
           TColgp_Array1OfDir& Nor)
   Though the normals are calcuted for the TopoDS_Face, but when output them to STL file, do not use these normals. The normals in STL file are normal of the triangle, not the vertex. So the function Normal() in StlTransfer.cxx can be removed.

Steps to reproduce

N/A

Public activity

2 archived notes

Participants are labeled by their role within this record.

01Commenter 2
StlTransfer (2) should be removed in scope of #0028840
02Commenter 2
Dear Commenter 1,

the issue has been fixed in scope of #0028840, this bug can be switched into VERIFIED state.

Related records