Archived issue #0024752
Visualization - inherit OpenGl_Group from Graphic3d_Group
Description
OpenGl_Group is logically specialization of Graphic3d_Group, but stored as pointer in it by current design.
Additional information
Graphic3d_Group is now abstract class and should be instantiated using Graphic3d_Structure::NewGroup() method.
Public activity
5 archived notes
Participants are labeled by their role within this record.
Patch is ready for review in CR24752_1 branch (history in CR24752).
Dear Commenter 1,
The branch is reviewed, please test.
The branch is reviewed, please test.
Dear Commenter 1,
Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms.
[revision removed]
There are compilation errors on Linux platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24752_1/job/mnt-CR24752_1-master_build_occt_linux/1/parsed_console/?
from ../../../../drv/AIS/AIS_DataMapIteratorOfDataMapOfSelStat_0.cxx:12:
../../../../inc/Handle_Prs3d_Presentation.hxx:17:42: error: Handle_Graphic3d_Structure.hxx: No such file or directory
error: Graphic3d_NameOfMaterial.hxx: No such file or directory
../../../../inc/PrsMgr_PresentationManager.hxx:20:49: error: Handle_Graphic3d_StructureManager.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:20:35: error: Graphic3d_Structure.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:32:53: error: Handle_Graphic3d_DataStructureManager.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:47:38: error: Handle_Graphic3d_Group.hxx: No such file or directory
....
Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms.
[revision removed]
There are compilation errors on Linux platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24752_1/job/mnt-CR24752_1-master_build_occt_linux/1/parsed_console/?
from ../../../../drv/AIS/AIS_DataMapIteratorOfDataMapOfSelStat_0.cxx:12:
../../../../inc/Handle_Prs3d_Presentation.hxx:17:42: error: Handle_Graphic3d_Structure.hxx: No such file or directory
error: Graphic3d_NameOfMaterial.hxx: No such file or directory
../../../../inc/PrsMgr_PresentationManager.hxx:20:49: error: Handle_Graphic3d_StructureManager.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:20:35: error: Graphic3d_Structure.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:32:53: error: Handle_Graphic3d_DataStructureManager.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:47:38: error: Handle_Graphic3d_Group.hxx: No such file or directory
....
Please re-test updated branch.
Dear Commenter 1,
Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 29 (29 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 390736656 / 391480644
Total CPU difference: 52837.32000000001 / 51357.52999999966
Testing on Windows:
Total MEMORY difference: 434611596 / 434230736
Total CPU difference: 42828.3125 / 35761.59375
There are no differences in images found by testdiff.
Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 29 (29 on master)
Windows: 0 (0 on master)
products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 390736656 / 391480644
Total CPU difference: 52837.32000000001 / 51357.52999999966
Testing on Windows:
Total MEMORY difference: 434611596 / 434230736
Total CPU difference: 42828.3125 / 35761.59375
There are no differences in images found by testdiff.
Related records