Archived issue #0024757

DRAW: Move commands fixshape, tolerance, and similar to MODELING

Open CASCADEOCCT:DRAWclosed7 public notes

Search issues

Description

For historic reasons, DRAW commands related to ShapeHealing component (fixshape etc.) are defined in package SWDRAW which is included in Data Exchange component of DRAW -- XSDRAW plugin. They should be moved to appropriate toolkit in Modeling part, TKTopTest.

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Package SWDRAW has been moved to TKTopTest toolkit. Class SWDRAW_ToVRML has been moved to XSDRAWSTLVRML_ToVRML

Removed unused classes:
SWDRAW_ShapeBuild
SWDRAW_ShapeConstruct
XSDRAW_Shape

Removed NSPApply command

Patch is ready to be reviewed in branch CR24757
02Commenter 2
No remarks, please test
03Commenter 3
Dear BugMaster,

Branch CR24757 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 27 (27 on master)
Windows: 0 (0 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
http://occt-tests/CR24757-master-occt/Debian60-64/summary.html
http://occt-tests/CR24757-master-occt/Windows-32-VC9/summary.html
heal elementary_to_revolution(012) A1, A2, A3, A4, A5

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 350794080 / 393133524
Total CPU difference: 61168.59999999981 / 57188.1899999999

Testing on Windows:
Total MEMORY difference: 359330672 / 414237744
Total CPU difference: 39693.625 / 42825.71875

There are no differences in images found by testdiff.
04Commenter 4
Test script has been updated. Please retest.
05Commenter 5
Another one update has been pushed. "xtrace" command has been removed as useless. Please test.
06Commenter 6
Branch is updated; please test ([revision removed])
07Commenter 7
Dear BugMaster,

Branch CR24757 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 27 (27 on master)
Windows: 0 (0 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 350446556 / 393242136
Total CPU difference: 63311.13999999993 / 57189.309999999896

Testing on Windows:
Total MEMORY difference: 367030604 / 414274688
Total CPU difference: 36880.46875 / 42798.984375

There are no differences in images found by testdiff.