OCCT3D
DiscussionsIssue archiveOCCT:Visualization

Archived issue #0024821

CLang warning -Wunsequenced in StdSelect_ViewerSelector3d

Open CASCADEOCCT:Visualizationclosed2 public notes

Search issues

Description

CLang produces two warnings on potential error in StdSelect:

StdSelect_ViewerSelector3d.cxx:770:38: warning: unsequenced modification and access to 'II' [-Wunsequenced]
StdSelect_ViewerSelector3d.cxx:837:34: warning: unsequenced modification and access to 'II' [-Wunsequenced]

Steps to reproduce

gp_Pnt ThePts[3] =
{
  gp_Pnt (C->GetPoint3d (II).XYZ()),
  gp_Pnt (C->GetPoint3d (++II).XYZ()),
  gp_Pnt (C->GetPoint3d (++II).XYZ())
};

Public activity

2 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Patch is ready for testing in branch CR24821.
02Commenter 2
Dear Commenter 3,

Branch CR24821 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)
MacOS: 411 (413 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 351519484 / 352642984
Total CPU difference: 50740.21 / 67343.19000000024

Testing on Windows:
Total MEMORY difference: 381076876 / 380685176
Total CPU difference: 34544.8125 / 39760.1875

There are no differences in images found by testdiff.