OCCT3D
DiscussionsIssue archiveOCCT:Coding

Archived issue #0024853

CLang warnings -Wunused-const-variable

Open CASCADEOCCT:Codingclosed3 public notes

Search issues

Description

CLang on Mac OS X 10.9 reports multiple warnings -Wunused-const-variable which in most cases indicate wrong code:
AIS_Dimension.cxx:83:35: warning: unused variable 'THE_FILL_CHARACTER' [-Wunused-const-variable]
OpenGl_Clipping.cxx:22:25: warning: unused variable 'OpenGl_DefaultPlaneEq' [-Wunused-const-variable]
OpenGl_Context.cxx:66:25: warning: unused variable 'OpenGl_DefaultPlaneEq' [-Wunused-const-variable]
NIS_TriangulatedDrawer.cxx:81:31: warning: unused variable 'nObjPerDrawer' [-Wunused-const-variable]

Public activity

3 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Unused variables were removed.
Changes are located in branch CR24853.
Please, review.
02Commenter 2
No remarks, please test
03Commenter 3
Dear Commenter 1,

Branch CR24853 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)
MacOS: 406 (410 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 355720308 / 355835048
Total CPU difference: 64746.87999999984 / 55266.74999999974

Testing on Windows:
Total MEMORY difference: 379177604 / 381847264
Total CPU difference: 35778.546875 / 43088.34375

There are no differences in images found by testdiff.