Archived issue #0024912
Remove unused Graphic3d_Strips
Description
Clang gives the following new warnings with 6.7.1:
src/Graphic3d/Graphic3d_Strips.cxx:248:7: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(cedge);
src/Graphic3d/Graphic3d_Strips.cxx:251:3: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(edges);
src/Graphic3d/Graphic3d_Strips.cxx:889:7: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(cedge);
src/Graphic3d/Graphic3d_Strips.cxx:892:3: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(edges);
This is allowed per C++11, however, this is prohibited in C++03. Better to make the template a global type.
src/Graphic3d/Graphic3d_Strips.cxx:248:7: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(cedge);
src/Graphic3d/Graphic3d_Strips.cxx:251:3: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(edges);
src/Graphic3d/Graphic3d_Strips.cxx:889:7: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(cedge);
src/Graphic3d/Graphic3d_Strips.cxx:892:3: warning:
template argument uses local type 'edg' [-Wlocal-type-template-args]
Standard::Free(edges);
This is allowed per C++11, however, this is prohibited in C++03. Better to make the template a global type.
Public activity
3 archived notes
Participants are labeled by their role within this record.
Dear Sergey,
the file looks abandoned and placed in wrong package - probably it is more reasonable to remove it entirely.
Could you please comment if there are any known users of this functionality?
the file looks abandoned and placed in wrong package - probably it is more reasonable to remove it entirely.
Could you please comment if there are any known users of this functionality?
Please check compilation of the patch in branch CR24912 - regression testing is not needed.
Dear Commenter 2,
Branch CR24912 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 201 (212 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Branch CR24912 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 201 (212 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Related records