DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0024921

ShapeAnalysis_Curve::ValidateRange doesn't adjust the range for periodic curves

CommunityOCCT:Modeling Algorithmsclosed3 public notes

Search issues

Description

Due to the false sequence of conditional checks ShapeAnalysis_Curve::ValidateRange function doens't fixes the bad ranges of periodic curves

Public activity

3 archived notes

Participants are labeled by their role within this record.

01Author
Please, review the patch
02Commenter 2
Branch CR0024991 is ready to be tested
03Commenter 1
Dear BugMaster,

Branch CR0024921 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 205 (212 on master)

products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 356654332 / 356598036
Total CPU difference: 60007.089999999786 / 51363.47999999977

Testing on Windows:
Total MEMORY difference: 379985740 / 380248492
Total CPU difference: 33671.359375 / 35796.078125

There are no differences in images found by testdiff.