Archived issue #0024924
ShapeFix_SplitTool doesn't verify the new range after cutting an edge
Description
At the current the new range for the curve calculated with respect to the cutting point isn't verified. In the most of the cases, the verification isn't necessary, since SplitTool expects the input range to be valid. But in case of periodic curves and cutting near 0 and 2*pi points the verification and the adjustment of the new range is necessary in order to bring to (0..2*pi) interval.
Public activity
7 archived notes
Participants are labeled by their role within this record.
Please, review the patch
Branch CR024924 is ready to be tested.
Dear BugMaster,
Branch CR024924 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 202 (205 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
mesh advanced_shading A8
http://occt-tests/CR24924-master-occt/Debian60-64/mesh/advanced_shading/A8.html
http://occt-tests/CR24924-master-occt/Windows-32-VC9/mesh/advanced_shading/A8.html
PRODUCTS:
omf advanced_meshcommon G1
omf advanced_meshfuse L8 ZF4
omf standard_meshtuc ZH6(Lin) ZH4(WNT)
http://jenkins-test-02.nnov.opencascade.com:8080/job/mnt-CR24924-master_products_tests_linux_start/
http://jenkins-test-02.nnov.opencascade.com:8080/job/mnt-CR24924-master_products_tests_windows_start/
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 355545280 / 355968116
Total CPU difference: 54533.899999999565 / 51289.87999999977
Testing on Windows:
Total MEMORY difference: 380050832 / 380248492
Total CPU difference: 35804.296875 / 35796.078125
Branch CR024924 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 202 (205 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
mesh advanced_shading A8
http://occt-tests/CR24924-master-occt/Debian60-64/mesh/advanced_shading/A8.html
http://occt-tests/CR24924-master-occt/Windows-32-VC9/mesh/advanced_shading/A8.html
PRODUCTS:
omf advanced_meshcommon G1
omf advanced_meshfuse L8 ZF4
omf standard_meshtuc ZH6(Lin) ZH4(WNT)
http://jenkins-test-02.nnov.opencascade.com:8080/job/mnt-CR24924-master_products_tests_linux_start/
http://jenkins-test-02.nnov.opencascade.com:8080/job/mnt-CR24924-master_products_tests_windows_start/
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 355545280 / 355968116
Total CPU difference: 54533.899999999565 / 51289.87999999977
Testing on Windows:
Total MEMORY difference: 380050832 / 380248492
Total CPU difference: 35804.296875 / 35796.078125
Seems that list of regression can not be determined by fix from branch CR24924.
Could you please re-base this branch on current master a retest re-basing branch.
Could you please re-base this branch on current master a retest re-basing branch.
It is necessary to create branch on current master containing commits from branches:
0024921,
0024924.
0024921,
0024924.
Branch CR24924_1 was created from commits 0024921 and 0024924.
Dear BugMaster,
Branch CR24924_1 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 202 (205 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 356402468 / 357316044
Total CPU difference: 53833.57999999992 / 56363.22999999993
Testing on Windows:
Total MEMORY difference: 379379620 / 379613888
Total CPU difference: 42130.015625 / 35503.203125
There are no differences in images found by testdiff.
Branch CR24924_1 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 202 (205 on master)
products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)
Regressions/Differences:
No regressions
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 356402468 / 357316044
Total CPU difference: 53833.57999999992 / 56363.22999999993
Testing on Windows:
Total MEMORY difference: 379379620 / 379613888
Total CPU difference: 42130.015625 / 35503.203125
There are no differences in images found by testdiff.