Visualization - SetMaterial/UnsetMaterial/UnsetColor are not implemented for AIS_TexturedShape

Dear kgv,

please review the patch in branch CR24930.

Dear Denis,

please provide test scenario for the issue.

+  if (!GetContext().IsNull())
+  {
+    if (GetContext()->MainPrsMgr()->HasPresentation (this, 3))
+    {

Please avoid using GetContext() here - see #0002883.
Shouldn't be UnsetMaterial() overridden as well?

Dear kgv,

please review the patch in branch CR24930_1.

284   if (!thePrs.IsNull())
285   {
286     Prs3d_Root::CurrentGroup (thePrs)->SetGroupPrimitivesAspect (myAspect);
287   }

Patch looks incomplete taking into account changes provided by #0002883 (iteration through all groups).

+    if (aGroup->IsGroupPrimitivesAspectSet (Graphic3d_ASPECT_FILL_AREA))
+    {
+      aGroup->SetGroupPrimitivesAspect (anAreaAsp);
+    }
+
+    updateAttributes (aPrsModed.Presentation()->Presentation());

What for all these extra steps if updateAttributes() calls SetGroupPrimitivesAspect() inside?

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Sep 29 15:35:22 2014 +0400

    0024930: Visualization - SetMaterial/UnsetMaterial/UnsetColor are not implemented for AIS_TexturedShape

Dear kgv,

please review the patch in branch CR24930_2.

Please test the patch.

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Dear Commenter 1,
Branch CR24930_2 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)
MacOS: 196 (196 on master)

products component :
Linux: 11 (11 on master)
Windows: 3 (3 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests/CR24930-2-master-occt/Debian60-64/bugs/vis/bug24930.html
http://occt-tests/CR24930-2-master-occt/Windows-32-VC10/bugs/vis/bug24930.html
bugs vis(004) bug24930: OK

Testing on Linux:
occt component :
Total MEMORY difference: 397634608 / 397680656
Total CPU difference: 42986.71000000001 / 46596.30000000006
products component :
Total MEMORY difference: 124723780 / 124607824
Total CPU difference: 14161.319999999996 / 14765.679999999953

Testing on Windows:
occt component :
Total MEMORY difference: 254858712 / 279236240
Total CPU difference: 32051.21875 / 39387.8125
products component :
Total MEMORY difference: 66912476 / 66932672
Total CPU difference: 10910.234375 / 11231.34375

There are no differences in images found by testdiff.

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Tue Sep 30 20:01:33 2014 +0400

    Correction of test case for issue CR24930

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]